Addonss: use standard Response object and don't sort response (#12334)

The json response isn't meant to be human-readable, sorting and
indenting is slow (30 times slower than just returning a normal
response). But this only noticeable with big responses, so in reality it
won't affect much of the performance. Also, since we are using DRF, we
should always return Response objects, they are the recommended way of
writing APIs. I wasn't able to remove one usage of JsonResponse, but we
should use an exception instead like suggested in
https://stackoverflow.com/questions/46713047/django-rest-framework-return-response-from-dispatch,
I didn't want to make a backwards compatible change here.

Author: stsewd

readthedocs/proxito/views/hosting.py

@@ -11,6 +11,7 @@
 from django.shortcuts import get_object_or_404
 from rest_framework import permissions
 from rest_framework.renderers import JSONRenderer
+from rest_framework.response import Response
 from rest_framework.views import APIView
 
 from readthedocs.api.mixins import CDNCacheTagsMixin
@@ -172,6 +173,8 @@ def dispatch(self, request, *args, **kwargs):
         project_slug = request.GET.get("project-slug")
         version_slug = request.GET.get("version-slug")
         if not url and (not project_slug or not version_slug):
+            # NOTE: we don't use Response because we can't return it from
+            # the dispatch method, we shuould refactor this to raise a subclass of APIException instead.
             return JsonResponse(
                 {
                     "error": "'project-slug' and 'version-slug' GET attributes are required when not sending 'url'"
@@ -184,7 +187,7 @@ def get(self, request, *args, **kwargs):
         url = request.GET.get("url")
         addons_version = request.GET.get("api-version")
         if not addons_version:
-            return JsonResponse(
+            return Response(
                 {"error": "'api-version' GET attribute is required"},
                 status=400,
             )
@@ -193,14 +196,14 @@ def get(self, request, *args, **kwargs):
             if addons_version.major not in ADDONS_VERSIONS_SUPPORTED:
                 raise ClientError
         except packaging.version.InvalidVersion:
-            return JsonResponse(
+            return Response(
                 {
                     "error": ClientError.VERSION_INVALID,
                 },
                 status=400,
             )
         except ClientError:
-            return JsonResponse(
+            return Response(
                 {"error": ClientError.VERSION_NOT_CURRENTLY_SUPPORTED},
                 status=400,
             )
@@ -216,7 +219,7 @@ def get(self, request, *args, **kwargs):
             filename=filename,
             url=url,
         )
-        return JsonResponse(data, json_dumps_params={"indent": 4, "sort_keys": True})
+        return Response(data)
 
 
 class NoLinksMixin: