Remove API_LARGE_DATA feature flag (#12309)

Closes #12293

Author: stsewd

readthedocs/doc_builder/environments.py

@@ -16,11 +16,9 @@
 from docker.errors import NotFound as DockerNotFoundError
 from requests.exceptions import ConnectionError
 from requests.exceptions import ReadTimeout
-from requests_toolbelt.multipart.encoder import MultipartEncoder
 
 from readthedocs.builds.models import BuildCommandResultMixin
 from readthedocs.core.utils import slugify
-from readthedocs.projects.models import Feature
 
 from .constants import DOCKER_HOSTNAME_MAX_LEN
 from .constants import DOCKER_IMAGE
@@ -270,35 +268,12 @@ def save(self, api_client):
 
         # If the command has an id, it means it has been saved before,
         # so we update it instead of creating a new one.
-        if self.build_env.project.has_feature(Feature.API_LARGE_DATA):
-            # Don't use slumber directly here. Slumber tries to enforce a string,
-            # which will break our multipart encoding here.
-            encoder = MultipartEncoder({key: str(value) for key, value in data.items()})
-            if self.id:
-                resource = api_client.command(self.id).patch
-                resp = resource._store["session"].patch(
-                    resource._store["url"],
-                    data=encoder,
-                    headers={
-                        "Content-Type": encoder.content_type,
-                    },
-                )
-            else:
-                resource = api_client.command.post
-                resp = resource._store["session"].post(
-                    resource._store["base_url"],
-                    data=encoder,
-                    headers={
-                        "Content-Type": encoder.content_type,
-                    },
-                )
-            log.debug("Response via multipart form.", response=resp)
+        if self.id:
+            resp = api_client.command(self.id).patch(data)
         else:
-            if self.id:
-                resp = api_client.command(self.id).patch(data)
-            else:
-                resp = api_client.command.post(data)
-            log.debug("Response via JSON encoded data.", response=resp)
+            resp = api_client.command.post(data)
+
+        log.debug("Response via JSON encoded data.", response=resp)
 
         self.id = resp.get("id")
 

readthedocs/projects/models.py

@@ -1944,7 +1944,6 @@ def add_features(sender, **kwargs):
 
     # Feature constants - this is not a exhaustive list of features, features
     # may be added by other packages
-    API_LARGE_DATA = "api_large_data"
     RECORD_404_PAGE_VIEWS = "record_404_page_views"
     DISABLE_PAGEVIEWS = "disable_pageviews"
     RESOLVE_PROJECT_FROM_HEADER = "resolve_project_from_header"
@@ -1973,10 +1972,6 @@ def add_features(sender, **kwargs):
     USE_S3_SCOPED_CREDENTIALS_ON_BUILDERS = "use_s3_scoped_credentials_on_builders"
 
     FEATURES = (
-        (
-            API_LARGE_DATA,
-            _("Build: Try alternative method of posting large data"),
-        ),
         (
             RECORD_404_PAGE_VIEWS,
             _("Proxito: Record 404s page views."),