Skip to content

Commit 3a4cdad

Browse files
authored
Build: log "Triggering build." with more data (#12374)
By calling this log line _after_ `prepare_build` we will be logging more useful infomation like `build_id` on this line together with all the options passed to the task. This is useful for debug.
1 parent 8e43dba commit 3a4cdad

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

readthedocs/core/utils/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,10 @@ def prepare_build(
179179
# Log all the extra options passed to the task
180180
structlog.contextvars.bind_contextvars(**options)
181181

182+
# NOTE: call this log here as well to log all the context variables added
183+
# inside this function. This is useful when debugging.
184+
log.info("Build created and ready to be executed.")
185+
182186
return (
183187
update_docs_task.signature(
184188
args=(

readthedocs/doc_builder/environments.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -835,8 +835,8 @@ def create_container(self):
835835
"Creating Docker container.",
836836
container_image=self.container_image,
837837
container_id=self.container_id,
838-
time_limit=self.container_time_limit,
839-
mem_limit=self.container_mem_limit,
838+
container_time_limit=self.container_time_limit,
839+
container_mem_limit=self.container_mem_limit,
840840
)
841841

842842
networking_config = None

0 commit comments

Comments
 (0)