Builds: feature flag to disable ACKS_LATE per project (#12354)

Another attempt to run builds longer than 1h in a reliably way.

Related: #12317

Author: humitos

readthedocs/core/utils/__init__.py

@@ -49,6 +49,7 @@ def prepare_build(
     from readthedocs.api.v2.models import BuildAPIKey
     from readthedocs.builds.models import Build
     from readthedocs.builds.tasks import send_build_notifications
+    from readthedocs.projects.models import Feature
     from readthedocs.projects.models import Project
     from readthedocs.projects.models import WebHookEvent
     from readthedocs.projects.tasks.builds import update_docs_task
@@ -171,6 +172,14 @@ def prepare_build(
 
     _, build_api_key = BuildAPIKey.objects.create_key(project=project)
 
+    # Disable ``ACKS_LATE`` for this particular build task to try out running builders longer than 1h.
+    # At 1h exactly, the task is grabbed by another worker and re-executed,
+    # even while it's still running on the original worker.
+    # https://github.com/readthedocs/readthedocs.org/issues/12317
+    if project.has_feature(Feature.BUILD_NO_ACKS_LATE):
+        log.info("Disabling ACKS_LATE for this particular build.")
+        options["acks_late"] = False
+
     return (
         update_docs_task.signature(
             args=(

readthedocs/projects/models.py

@@ -1977,6 +1977,7 @@ def add_features(sender, **kwargs):
     SCALE_IN_PROTECTION = "scale_in_prtection"
     USE_S3_SCOPED_CREDENTIALS_ON_BUILDERS = "use_s3_scoped_credentials_on_builders"
     BUILD_HEALTHCHECK = "build_healthcheck"
+    BUILD_NO_ACKS_LATE = "build_no_acks_late"
 
     FEATURES = (
         (
@@ -2055,6 +2056,10 @@ def add_features(sender, **kwargs):
             BUILD_HEALTHCHECK,
             _("Build: Use background cURL healthcheck."),
         ),
+        (
+            BUILD_NO_ACKS_LATE,
+            _("Build: Do not use Celery ASK_LATE config for this project."),
+        ),
     )
 
     FEATURES = sorted(FEATURES, key=lambda x: x[1])