Build: healthcheck only on builds (#12418)

humitos · web-flow · commit 4f325f1d4dd1 · 2025-08-18T20:29:54.000+02:00
Skip healthcheck if the environment is initialized without a build. This
is because we share the environment class with sync versions task as
well.
diff --git a/readthedocs/doc_builder/environments.py b/readthedocs/doc_builder/environments.py
@@ -862,7 +862,9 @@ def create_container(self):
             )
             client.start(container=self.container_id)
 
-            if self.project.has_feature(Feature.BUILD_HEALTHCHECK):
+            # NOTE: as this environment is used for `sync_repository_task` it may
+            # not have a build associated. We skip running a healthcheck on those cases.
+            if self.project.has_feature(Feature.BUILD_HEALTHCHECK) and self.build:
                 self._run_background_healthcheck()
 
         except (DockerAPIError, ConnectionError) as exc:

Original file line number	Diff line number	Diff line change
`@@ -862,7 +862,9 @@ def create_container(self):`
`862`	`862`	`)`
`863`	`863`	`client.start(container=self.container_id)`
`864`	`864`
`865`		`- if self.project.has_feature(Feature.BUILD_HEALTHCHECK):`
	`865`	+ # NOTE: as this environment is used for `sync_repository_task` it may
	`866`	`+ # not have a build associated. We skip running a healthcheck on those cases.`
	`867`	`+ if self.project.has_feature(Feature.BUILD_HEALTHCHECK) and self.build:`
`866`	`868`	`self._run_background_healthcheck()`
`867`	`869`
`868`	`870`	`except (DockerAPIError, ConnectionError) as exc:`