Use hashed static files (#12274)

Attempt to fix
readthedocs/readthedocs-ops#1650

Author: ericholscher

readthedocs/settings/base.py

@@ -409,6 +409,8 @@ def MIDDLEWARE(self):
     RTD_BUILD_COMMANDS_STORAGE = (
         "readthedocs.builds.storage.BuildMediaFileSystemStorage"
     )
+    # This is for serving static files on proxito, not Django static files
+    # https://github.com/readthedocs/readthedocs.org/pull/9237
     RTD_STATICFILES_STORAGE = "readthedocs.builds.storage.StaticFilesStorage"
 
     @property
@@ -1058,7 +1060,7 @@ def STORAGES(self):
         # https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html
         return {
             "staticfiles": {
-                "BACKEND": self.RTD_STATICFILES_STORAGE,
+                "BACKEND": "readthedocs.storage.s3_storage.S3StaticStorage"
             },
         }
 

readthedocs/settings/docker_compose.py

@@ -177,7 +177,6 @@ def DATABASES(self):  # noqa
     # Storage backend for build languages
     RTD_BUILD_TOOLS_STORAGE = "readthedocs.storage.s3_storage.S3BuildToolsStorage"
     # Storage for static files (those collected with `collectstatic`)
-    STATICFILES_STORAGE = "readthedocs.storage.s3_storage.S3StaticStorage"
     RTD_STATICFILES_STORAGE = "readthedocs.storage.s3_storage.NoManifestS3StaticStorage"
 
     AWS_ACCESS_KEY_ID = os.environ.get("RTD_AWS_ACCESS_KEY_ID", "admin")

readthedocs/settings/test.py

@@ -130,5 +130,18 @@ def LOGGING(self):  # noqa - avoid pep8 N802
         logging["disable_existing_loggers"] = False
         return logging
 
+    @property
+    def STORAGES(self):
+        # Attempt to fix tests using the default storage backends
+        return {
+            "default": {
+                "BACKEND": "django.core.files.storage.FileSystemStorage",
+            },
+            "staticfiles": {
+                "BACKEND": "django.contrib.staticfiles.storage.StaticFilesStorage",
+            },
+        }
+
+
 
 CommunityTestSettings.load_settings(__name__)