Skip to content

Commit 5dc0b3c

Browse files
authored
Be defensive with build_complete signal (#11973)
1 parent 3916a53 commit 5dc0b3c

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

readthedocs/projects/tasks/builds.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,11 @@ def after_return(self, status, retval, task_id, args, kwargs, einfo):
752752
self.update_build(build_state)
753753
self.save_build_data()
754754

755-
build_complete.send(sender=Build, build=self.data.build)
755+
# Be defensive with the signal, so if a listener fails we still clean up
756+
try:
757+
build_complete.send(sender=Build, build=self.data.build)
758+
except Exception:
759+
log.exception("Error during build_complete", exc_info=True)
756760

757761
if self.data.version:
758762
clean_build(self.data.version)

0 commit comments

Comments
 (0)