Notification: fix choices rendering for INVALID_CHOICE (#11190)

* Notification: fix `choices` rendering for `INVALID_CHOICE`

While taking a look at #11189 I found that the rendering was broken.
I found the `with` + `yield` pattern pretty complex (I have a note about this in
the code) and it seems that complexity is confusing enough to make this hard to
dealt with.

Anyways, I fixed the problem for now and I added a test case. We can come back
to refactoring this in the future with more time.

* Update readthedocs/config/config.py

Co-authored-by: Santos Gallegos <[email protected]>

---------

Co-authored-by: Santos Gallegos <[email protected]>

Author: humitos

readthedocs/config/config.py

@@ -112,13 +112,20 @@ def catch_validation_error(self, key):
         try:
             yield
         except ConfigValidationError as error:
-            raise ConfigError(
-                message_id=error.message_id,
-                format_values={
+            # Expand the format values defined when the exception is risen
+            # with extra ones we have here
+            format_values = getattr(error, "format_values", {})
+            format_values.update(
+                {
                     "key": key,
                     "value": error.format_values.get("value"),
                     "source_file": os.path.relpath(self.source_file, self.base_path),
-                },
+                }
+            )
+
+            raise ConfigError(
+                message_id=error.message_id,
+                format_values=format_values,
             ) from error
 
     def pop(self, name, container, default, raise_ex):

readthedocs/config/tests/test_config.py

@@ -424,6 +424,9 @@ def test_new_build_config_invalid_tools_version(self):
             build.validate()
         assert excinfo.value.message_id == ConfigValidationError.INVALID_CHOICE
         assert excinfo.value.format_values.get("key") == "build.tools.python"
+        assert excinfo.value.format_values.get("choices") == ", ".join(
+            settings.RTD_DOCKER_BUILD_SETTINGS["tools"]["python"].keys()
+        )
 
     def test_new_build_config(self):
         build = get_build_config(