revert test_build_tasks

Author: silentfatez

readthedocs/projects/tests/test_build_tasks.py

@@ -301,15 +301,9 @@ def test_build_updates_documentation_type(self, load_yaml_config):
         self._trigger_update_docs_task()
 
         # Update version state
-        patch_request = None
-        for req in self.requests_mock.request_history[7:]:
-            if req._request.method == "PATCH" and req.path == "/api/v2/version/1/":
-                patch_request = req
-                break
-
-        assert patch_request._request.method == "PATCH"
-        assert patch_request.path == "/api/v2/version/1/"
-        assert patch_request.json() == {
+        assert self.requests_mock.request_history[8]._request.method == "PATCH"
+        assert self.requests_mock.request_history[8].path == "/api/v2/version/1/"
+        assert self.requests_mock.request_history[8].json() == {
             "addons": False,
             "build_data": None,
             "built": True,
@@ -2012,19 +2006,23 @@ def test_mkdocs_fail_on_warning(self, load_yaml_config):
 
         self._trigger_update_docs_task()
 
-        self.mocker.mocks["environment.run"].assert_any_call(
-            mock.ANY,
-            "-m",
-            "mkdocs",
-            "build",
-            "--clean",
-            "--site-dir",
-            "$READTHEDOCS_OUTPUT/html",
-            "--config-file",
-            "docs/mkdocs.yaml",
-            "--strict",
-            cwd=mock.ANY,
-            bin_path=mock.ANY,
+        self.mocker.mocks["environment.run"].assert_has_calls(
+            [
+                mock.call(
+                    mock.ANY,
+                    "-m",
+                    "mkdocs",
+                    "build",
+                    "--clean",
+                    "--site-dir",
+                    "$READTHEDOCS_OUTPUT/html",
+                    "--config-file",
+                    "docs/mkdocs.yaml",
+                    "--strict",  # fail on warning flag
+                    cwd=mock.ANY,
+                    bin_path=mock.ANY,
+                )
+            ]
         )
 
     @mock.patch("readthedocs.doc_builder.director.load_yaml_config")