Upgrade to Django 5.x (#12104)

Upgrade our code base to Django 5.2

- `django-safemigrate` had to be upgraded: you will find _a lot of_
changes like `Safe.before_deploy` -> `Safe.before_deploy()` (all of them
are in this particular commit: 4273e83)
- I had to borrow `django.core.files.storage.get_storage_class` because
it was deleted from Django 5.2
- `assertFormError` tests were updated to match the new signature
- `django-celery-beat` and `django-storages` were upgraded
- Update some old migrations referring to indexes to make them work

Closes #12079 
Closes #11505

Author: humitos

common

@@ -41,7 +41,7 @@ You can achieve this by following these steps:
               self.fields["new_field"].empty_value = False
 
 #. Create the migration file (let's call this migration ``app 0001``),
-   and mark it as ``Safe.before_deploy``.
+   and mark it as ``Safe.before_deploy()``.
 
    .. code-block:: python
 
@@ -50,10 +50,10 @@ You can achieve this by following these steps:
 
 
       class Migration(migrations.Migration):
-          safe = Safe.before_deploy
+          safe = Safe.before_deploy()
 
 #. Create a data migration to populate all null values of the new field with a proper value (let's call this migration ``app 0002``),
-   and mark it as ``Safe.after_deploy``.
+   and mark it as ``Safe.after_deploy()``.
 
    .. code-block:: python
 
@@ -66,14 +66,14 @@ You can achieve this by following these steps:
 
 
        class Migration(migrations.Migration):
-           safe = Safe.after_deploy
+           safe = Safe.after_deploy()
 
            operations = [
                migrations.RunPython(migrate),
            ]
 
 #. After the deploy has been completed, create a new migration to set the field as non-nullable (let's call this migration ``app 0003``).
-   Run this migration on a new deploy, you can mark it as ``Safe.before_deploy`` or ``Safe.always``.
+   Run this migration on a new deploy, you can mark it as ``Safe.before_deploy()`` or ``Safe.always()``.
 #. Remove any handling of the null case from the code.
 
 At the end, the deploy should look like this:
@@ -102,7 +102,7 @@ You can achieve this by following these steps:
           field_to_delete = models.CharField(max_length=100, null=True, blank=True)
 
 #. Create the migration file (let's call this migration ``app 0001``),
-   and mark it as ``Safe.before_deploy``.
+   and mark it as ``Safe.before_deploy()``.
 
    .. code-block:: python
 
@@ -111,10 +111,10 @@ You can achieve this by following these steps:
 
 
       class Migration(migrations.Migration):
-          safe = Safe.before_deploy
+          safe = Safe.before_deploy()
 
 #. Create a migration to remove the field from the database (let's call this migration ``app 0002``),
-   and mark it as ``Safe.after_deploy``.
+   and mark it as ``Safe.after_deploy()``.
 
    .. code-block:: python
 
@@ -123,7 +123,7 @@ You can achieve this by following these steps:
 
 
       class Migration(migrations.Migration):
-          safe = Safe.after_deploy
+          safe = Safe.after_deploy()
 
 At the end, the deploy should look like this:
 

docs/dev/migrations.rst

@@ -22,6 +22,6 @@ filterwarnings =
     ignore:DateTimeField .* received a naive datetime .* while time zone support is active:RuntimeWarning
     ignore:.*:DeprecationWarning
 
-    ignore:.*:django.utils.deprecation.RemovedInDjango50Warning
+    ignore:.*:django.utils.deprecation.RemovedInDjango60Warning
     ignore:.*:elasticsearch.exceptions.ElasticsearchWarning
     ignore:.*:PendingDeprecationWarning

pytest.ini

@@ -8,7 +8,7 @@
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     initial = True
 
     dependencies = [

readthedocs/analytics/migrations/0001_initial.py

@@ -6,7 +6,7 @@
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     dependencies = [
         ("builds", "0041_track_task_id"),
         ("projects", "0087_use_booleanfield_null"),

readthedocs/analytics/migrations/0002_track_status_code.py

@@ -7,7 +7,7 @@
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     dependencies = [
         ("analytics", "0002_track_status_code"),
     ]

readthedocs/analytics/migrations/0003_remove_index.py

@@ -29,7 +29,7 @@ def forwards_func(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     dependencies = [
         ("analytics", "0003_remove_index"),
     ]

readthedocs/analytics/migrations/0004_merge_duplicate_records.py

@@ -5,7 +5,7 @@
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     dependencies = [
         ("analytics", "0004_merge_duplicate_records"),
     ]

readthedocs/analytics/migrations/0005_add_unique_constraint.py

@@ -5,7 +5,7 @@
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     dependencies = [
         ("analytics", "0005_add_unique_constraint"),
     ]

readthedocs/analytics/migrations/0006_alter_pageview_id.py

@@ -7,7 +7,7 @@
 
 
 class Migration(migrations.Migration):
-    safe = Safe.after_deploy
+    safe = Safe.after_deploy()
     dependencies = [
         ("analytics", "0006_alter_pageview_id"),
     ]