Profile: don't duplicate annotation in queryset (#12405)

This is already done in the query iself

#12385

Author: stsewd

readthedocs/core/templatetags/privacy_tags.py

@@ -1,10 +1,7 @@
 """Template tags to query projects by privacy."""
 
 from django import template
-from django.db.models import Exists
-from django.db.models import OuterRef
 
-from readthedocs.builds.models import Build
 from readthedocs.core.permissions import AdminPermission
 from readthedocs.projects.models import Project
 
@@ -24,14 +21,9 @@ def is_member(user, project):
 
 @register.simple_tag(takes_context=True)
 def get_public_projects(context, user):
-    # 'Exists()' checks if the project has any good builds.
-    projects = (
-        Project.objects.for_user_and_viewer(
-            user=user,
-            viewer=context["request"].user,
-        )
-        .prefetch_latest_build()
-        .annotate(_good_build=Exists(Build.internal.filter(success=True, project=OuterRef("pk"))))
-    )
+    projects = Project.objects.for_user_and_viewer(
+        user=user,
+        viewer=context["request"].user,
+    ).prefetch_latest_build()
     context["public_projects"] = projects
     return ""