Revert "Service: kwargs only when sending build statuses"

This reverts commit 7615e0e.

Author: stsewd

readthedocs/builds/tasks.py

@@ -416,9 +416,9 @@ def send_build_status(build_pk, commit, status):
 
     for service in service_class.for_project(build.project):
         success = service.send_build_status(
-            build=build,
-            commit=commit,
-            status=status,
+            build,
+            commit,
+            status,
         )
         if success:
             log.debug("Build status report sent correctly.")

readthedocs/oauth/services/base.py

@@ -86,7 +86,7 @@ def update_webhook(self, project, integration):
         """
         raise NotImplementedError
 
-    def send_build_status(self, *, build, commit, status):
+    def send_build_status(self, build, commit, status):
         """
         Create commit status for project.
 

readthedocs/oauth/services/github.py

@@ -406,7 +406,7 @@ def update_webhook(self, project, integration):
 
         return (False, resp)
 
-    def send_build_status(self, *, build, commit, status):
+    def send_build_status(self, build, commit, status):
         """
         Create GitHub commit status for project.
 

readthedocs/oauth/services/gitlab.py

@@ -495,7 +495,7 @@ def update_webhook(self, project, integration):
 
         return (False, resp)
 
-    def send_build_status(self, *, build, commit, status):
+    def send_build_status(self, build, commit, status):
         """
         Create GitLab commit status for project.
 

readthedocs/rtd_tests/tests/test_oauth.py

@@ -305,9 +305,7 @@ def test_multiple_users_same_repo(self):
     def test_send_build_status_successful(self, session, mock_logger):
         session.post.return_value.status_code = 201
         success = self.service.send_build_status(
-            build=self.external_build,
-            commit=self.external_build.commit,
-            status=BUILD_STATUS_SUCCESS,
+            self.external_build, self.external_build.commit, BUILD_STATUS_SUCCESS
         )
 
         self.assertTrue(success)
@@ -321,9 +319,7 @@ def test_send_build_status_successful(self, session, mock_logger):
     def test_send_build_status_404_error(self, session, mock_logger):
         session.post.return_value.status_code = 404
         success = self.service.send_build_status(
-            build=self.external_build,
-            commit=self.external_build.commit,
-            status=BUILD_STATUS_SUCCESS,
+            self.external_build, self.external_build.commit, BUILD_STATUS_SUCCESS
         )
 
         self.assertFalse(success)
@@ -337,9 +333,7 @@ def test_send_build_status_404_error(self, session, mock_logger):
     def test_send_build_status_value_error(self, session, mock_logger):
         session.post.side_effect = ValueError
         success = self.service.send_build_status(
-            build=self.external_build,
-            commit=self.external_build.commit,
-            status=BUILD_STATUS_SUCCESS,
+            self.external_build, self.external_build.commit, BUILD_STATUS_SUCCESS
         )
 
         self.assertFalse(success)
@@ -1169,9 +1163,7 @@ def test_send_build_status_successful(self, repo_id, session, mock_logger):
         repo_id().return_value = "9999"
 
         success = self.service.send_build_status(
-            build=self.external_build,
-            commit=self.external_build.commit,
-            status=BUILD_STATUS_SUCCESS,
+            self.external_build, self.external_build.commit, BUILD_STATUS_SUCCESS
         )
 
         self.assertTrue(success)
@@ -1188,9 +1180,7 @@ def test_send_build_status_404_error(self, repo_id, session, mock_logger):
         repo_id.return_value = "9999"
 
         success = self.service.send_build_status(
-            build=self.external_build,
-            commit=self.external_build.commit,
-            status=BUILD_STATUS_SUCCESS,
+            self.external_build, self.external_build.commit, BUILD_STATUS_SUCCESS
         )
 
         self.assertFalse(success)
@@ -1207,9 +1197,7 @@ def test_send_build_status_value_error(self, repo_id, session, mock_logger):
         repo_id().return_value = "9999"
 
         success = self.service.send_build_status(
-            build=self.external_build,
-            commit=self.external_build.commit,
-            status=BUILD_STATUS_SUCCESS,
+            self.external_build, self.external_build.commit, BUILD_STATUS_SUCCESS
         )
 
         self.assertFalse(success)