Project: add is_github_app_project helper method (#12193)

This is also going to be used in the templates

Author: stsewd

readthedocs/projects/forms.py

@@ -25,7 +25,6 @@
 from readthedocs.core.utils.extend import SettingsOverrideObject
 from readthedocs.integrations.models import Integration
 from readthedocs.invitations.models import Invitation
-from readthedocs.oauth.constants import GITHUB_APP
 from readthedocs.oauth.models import RemoteRepository
 from readthedocs.organizations.models import Team
 from readthedocs.projects.constants import ADDONS_FLYOUT_SORTING_CUSTOM_PATTERN
@@ -231,8 +230,7 @@ def clean_prevalidation(self):
         """Disable the external builds option if the project doesn't meet the requirements."""
         # If the project is attached to a GitHub app integration,
         # it will always be able to build external versions.
-        remote_repository = self.instance.remote_repository
-        if remote_repository and remote_repository.vcs_provider == GITHUB_APP:
+        if self.instance.is_github_app_project:
             return
 
         integrations = list(self.instance.integrations.all())

readthedocs/projects/models.py

@@ -40,6 +40,7 @@
 from readthedocs.domains.querysets import DomainQueryset
 from readthedocs.domains.validators import check_domains_limit
 from readthedocs.notifications.models import Notification as NewNotification
+from readthedocs.oauth.constants import GITHUB_APP
 from readthedocs.projects import constants
 from readthedocs.projects.exceptions import ProjectConfigurationError
 from readthedocs.projects.managers import HTMLFileManager
@@ -1013,6 +1014,10 @@ def is_github_project(self):
             GitHubAppService,
         ]
 
+    @property
+    def is_github_app_project(self):
+        return self.remote_repository and self.remote_repository.vcs_provider == GITHUB_APP
+
     @property
     def is_gitlab_project(self):
         from readthedocs.oauth.services import GitLabService