Handle explicit intersphinx inventory names in all domains (#236)

fix: handle intersphinx inventory names in all domains

Co-authored-by: Manuel Kaufmann <[email protected]>

Author: shiftinv

hoverxref/extension.py

@@ -222,19 +222,18 @@ def missing_reference(app, env, node, contnode):
     skip_node = True
     inventory_name_matched = None
 
-    if domain == 'std':
-        # Using ``:ref:`` manually, we could write intersphinx like:
+    if ':' in target:
+        # Using intersphinx with an explicit inventory name like:
         # :ref:`datetime <python:datetime.datetime>`
         # and the node will have these attribues:
         #   refdomain: std
         #   reftype: ref
         #   reftarget: python:datetime.datetime
         #   refexplicit: True
-        if ':' in target:
-            inventory_name, _ = target.split(':', 1)
-            if inventory_name in app.config.hoverxref_intersphinx:
-                skip_node = False
-                inventory_name_matched = inventory_name
+        inventory_name, _ = target.split(':', 1)
+        if inventory_name in app.config.hoverxref_intersphinx:
+            skip_node = False
+            inventory_name_matched = inventory_name
 
     # Skip this node completely if the domain is empty (`None` or `''`).
     # I found this happens in weird scenarios.

tests/examples/intersphinx/index.rst

@@ -5,6 +5,7 @@ This is an example page.
 
 :ref:`This a :ref: to The Python Tutorial using intersphinx <python:tutorial-index>`.
 :ref:`This a :ref: to datetime.datetime Python's function using intersphinx <python:datetime-datetime>`.
+:py:attr:`Python's datetime.time.minute <python:datetime.time.minute>`.
 
 :ref:`This a :ref: to Config File v2 Read the Docs' page using intersphinx <readthedocs:config-file/v2:python>`.
 

tests/test_htmltag.py

@@ -351,6 +351,7 @@ def test_intersphinx_all_mappings(app, status, warning):
         # Python's links do have hoverxref enabled
         r'<a class="hxr-hoverxref hxr-tooltip reference external" href="https://docs.python.org/3/tutorial/index.html#tutorial-index" title="\(in Python v3.\d\d?\)"><span class="xref std std-ref">This a :ref: to The Python Tutorial using intersphinx</span></a>',
         r'<a class="hxr-hoverxref hxr-tooltip reference external" href="https://docs.python.org/3/library/datetime.html#datetime-datetime" title="\(in Python v3.\d\d?\)"><span class="xref std std-ref">This a :ref: to datetime.datetime Python’s function using intersphinx</span></a>',
+        r'<a class="hxr-hoverxref hxr-tooltip reference external" href="https://docs.python.org/3/library/datetime.html#datetime.time.minute" title="\(in Python v3.\d\d?\)"><code class="xref py py-attr docutils literal notranslate"><span class="pre">Python\'s</span> <span class="pre">datetime.time.minute</span></code></a>',
         r'<a class="hxr-hoverxref hxr-modal reference external" href="https://docs.python.org/3/library/functions.html#float" title="\(in Python v3.\d\d?\)"><code class="xref py py-class docutils literal notranslate"><span class="pre">float</span></code></a>',
 
         # Read the Docs' link does have hoverxref enabled