Skip to content

Commit 3ed52c4

Browse files
authored
Don't toggle terminal nodes (#1049)
Terminal nodes that are already selected shouldn't be toggled. Fix #1044
1 parent 6d89d9d commit 3ed52c4

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

sphinx_rtd_theme/static/js/theme.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/theme.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,12 @@ function ThemeNav () {
192192
var parent_li = elem.closest('li');
193193
parent_li.siblings('li.current').removeClass('current');
194194
parent_li.siblings().find('li.current').removeClass('current');
195-
parent_li.find('> ul li.current').removeClass('current');
196-
parent_li.toggleClass('current');
195+
var children = parent_li.find('> ul li');
196+
// Don't toggle terminal elements.
197+
if (children.length) {
198+
children.removeClass('current');
199+
parent_li.toggleClass('current');
200+
}
197201
}
198202

199203
return nav;

0 commit comments

Comments
 (0)