Skip to content

Commit 4d8bf48

Browse files
committed
Make version picker keyboard-controllable
1 parent ef9a058 commit 4d8bf48

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

sphinx_rtd_theme/versions.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{% if READTHEDOCS %}
22
{# Add rst-badge after rst-versions for small badge style. #}
33
<div class="rst-versions" data-toggle="rst-versions" role="note" aria-label="{{ _('Versions') }}">
4-
<span class="rst-current-version" data-toggle="rst-current-version">
4+
<button class="rst-current-version" data-toggle="rst-current-version">
55
<span class="fa fa-book"> Read the Docs</span>
66
v: {{ current_version }}
77
<span class="fa fa-caret-down"></span>
8-
</span>
8+
</button>
99
<div class="rst-other-versions">
1010
<dl>
1111
<dt>{{ _('Versions') }}</dt>

src/sass/_theme_badge.sass

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
font-size: 90%
2121
cursor: pointer
2222
color: $green
23+
width: 100%
2324
+clearfix
2425
.fa
2526
color: $section-background-color

src/theme.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,13 @@ function ThemeNav () {
9595
self.hashChange();
9696
})
9797
.on('click', "[data-toggle='rst-current-version']", function() {
98+
var target = $(this);
9899
$("[data-toggle='rst-versions']").toggleClass("shift-up");
100+
target.attr(
101+
'aria-expanded',
102+
$("[data-toggle='rst-versions']").hasClass("shift-up") ?
103+
"true" : "false"
104+
);
99105
})
100106

101107
// Make tables responsive

0 commit comments

Comments
 (0)