Skip to content

Commit a732d61

Browse files
authored
Merge pull request #804 from readthedocs/agj/force-neat-19
Comment on why bourbon-neat is pinned
2 parents 78287f0 + abc57aa commit a732d61

File tree

3 files changed

+22
-2
lines changed

3 files changed

+22
-2
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*.map
1010
.ropeproject/
1111
.ruby-version
12-
bin/
1312
dist/
1413
bower_components/
1514
include/

bin/preinstall.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
#!/usr/bin/env node
2+
3+
const package = require('../package.json');
4+
5+
// Sorry everyone, this is the closest we can get to commenting on package.json
6+
// dependencies :(
7+
if (package.devDependencies['bourbon-neat'] !== '~1.9') {
8+
// Wyrm is not compatible with Neat 2.0+, and Neat 1.9 at least pins a
9+
// node-sass version that doesn't require Python 2. The changes to Wyrm to
10+
// support Neat 2.0+ are all fairly minor changes, but it deeply affects the
11+
// grid system and might be more of a liability than an old release of Neat.
12+
// See: https://github.com/readthedocs/sphinx_rtd_theme/pull/771
13+
console.error(
14+
'bourbon-neat 1.9 is required, Wyrm is not compatible with Neat 2.0+.'
15+
);
16+
console.error(
17+
'The expected selector for the bourbon-neat dependency in package.json is "~1.9".'
18+
);
19+
process.exit(1);
20+
}

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
"private": true,
66
"scripts": {
77
"dev": "webpack-dev-server --open --config webpack.dev.js",
8-
"build": "webpack --config webpack.prod.js"
8+
"build": "webpack --config webpack.prod.js",
9+
"preinstall": "bin/preinstall.js"
910
},
1011
"dependencies": {},
1112
"devDependencies": {

0 commit comments

Comments
 (0)