Remove all instances of READTHEDOCS

The removes all the if checks for read the docs.

On read the docs builds this content is now injected. However, we want to support non read the docs builds and provide a way to generate the version menu.

This diff includes changes from #578 and #983

Author: Blendify

docs/configuring.rst

@@ -172,6 +172,13 @@ Miscellaneous options
     :type: string
     :default: ``#2980B9``
 
+.. confval:: versions_menu
+
+    Whether or not to show the bottom left menu listing the versions and links
+    to VCS repository.
+
+    :type: boolean
+    :default: True
 
 File-wide metadata
 ==================

sphinx_rtd_theme/layout.html

@@ -137,7 +137,7 @@
 
           {%- if theme_display_version %}
             {%- set nav_version = version %}
-            {%- if READTHEDOCS and current_version %}
+            {%- if current_version %}
               {%- set nav_version = current_version %}
             {%- endif %}
             {%- if nav_version %}
@@ -215,8 +215,7 @@
       });
   </script>
 
-  {#- Do not conflict with RTD insertion of analytics script #}
-  {%- if not READTHEDOCS %}
+  {%- block analytics %}
     {%- if theme_analytics_id %}
     <!-- Theme Analytics -->
     <script>
@@ -233,7 +232,7 @@
     </script>
 
     {%- endif %}
-  {%- endif %}
+  {%- endblock %}
 
   {%- block footer %} {% endblock %}
 

sphinx_rtd_theme/theme.conf

@@ -18,3 +18,4 @@ prev_next_buttons_location = bottom
 style_external_links = False
 style_nav_header_background =
 vcs_pageview_mode =
+versions_menu = True

sphinx_rtd_theme/versions.html

@@ -1,34 +1,30 @@
-{% if READTHEDOCS %}
+{%- block versions_menu %}
+{%- if theme_versions_menu|tobool %}
 {# Add rst-badge after rst-versions for small badge style. #}
   <div class="rst-versions" data-toggle="rst-versions" role="note" aria-label="{{ _('Versions') }}">
     <span class="rst-current-version" data-toggle="rst-current-version">
-      <span class="fa fa-book"> Read the Docs</span>
+      <span class="fa fa-book"> {{ project }}</span>
       v: {{ current_version }}
       <span class="fa fa-caret-down"></span>
     </span>
     <div class="rst-other-versions">
+      {%- block versions %}
       <dl>
         <dt>{{ _('Versions') }}</dt>
         {% for slug, url in versions %}
           <dd><a href="{{ url }}">{{ slug }}</a></dd>
         {% endfor %}
       </dl>
+      {%- endblock %}
+      {%- block downloads %}
       <dl>
         <dt>{{ _('Downloads') }}</dt>
         {% for type, url in downloads %}
           <dd><a href="{{ url }}">{{ type }}</a></dd>
         {% endfor %}
       </dl>
-      <dl>
-        {# Translators: The phrase "Read the Docs" is not translated #}
-        <dt>{{ _('On Read the Docs') }}</dt>
-          <dd>
-            <a href="//{{ PRODUCTION_DOMAIN }}/projects/{{ slug }}/?fromdocs={{ slug }}">{{ _('Project Home') }}</a>
-          </dd>
-          <dd>
-            <a href="//{{ PRODUCTION_DOMAIN }}/builds/{{ slug }}/?fromdocs={{ slug }}">{{ _('Builds') }}</a>
-          </dd>
-      </dl>
+      {%- endblock %}
     </div>
   </div>
 {% endif %}
+{%- endblock %}