-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
ImprovementMinor improvement to codeMinor improvement to codeNeeded: design decisionA core team decision is requiredA core team decision is required
Description
In the translation workflow, Babel adds helper scripts to setup.py, and #778 added some helpers to call all of the required translation pieces.
#771 uses a standard npm run to wrap around the webpack calls, however would it make more sense to also put these in setup.py? We could even extend the build command class to execute the webpack build prior to the rest of the packaging build steps.
python setup.py buildis consistent and fits with our release packaging. It keeps commands in a singular placenpm run buildimplies that the build process requires npm and installation through npm- Middle ground:
python seutp.py buildcallsnpm run build, it's all about choices.
Which are you most likely to use (or want to use)?
Metadata
Metadata
Assignees
Labels
ImprovementMinor improvement to codeMinor improvement to codeNeeded: design decisionA core team decision is requiredA core team decision is required