Skip to content

Put all build commands in setup.py command classes #797

@agjohnson

Description

@agjohnson

In the translation workflow, Babel adds helper scripts to setup.py, and #778 added some helpers to call all of the required translation pieces.

#771 uses a standard npm run to wrap around the webpack calls, however would it make more sense to also put these in setup.py? We could even extend the build command class to execute the webpack build prior to the rest of the packaging build steps.

  • python setup.py build is consistent and fits with our release packaging. It keeps commands in a singular place
  • npm run build implies that the build process requires npm and installation through npm
  • Middle ground: python seutp.py build calls npm run build, it's all about choices.

Which are you most likely to use (or want to use)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions