Tests: Run against nav toctree and not builtin toctree #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the test were checking the `.. toctree::` directive and not the navigation toctree in our template. This is now fixed. A white space change was made so we dont have to include the white space in the search string. The test project was update to not collapse the navigation and to use infinite toc depth to match the old test case.
benjaoming
approved these changes
Aug 27, 2022
|
Since the tests don't pass, we would need some more work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the test were checking the
.. toctree::directive and not the navigation toctree in our template. This is now fixed.A white space change was made so we dont have to include the white space in the search string.
The test project was update to not collapse the navigation and to use infinite toc depth to match the old test case.