Cleanup: Use page_source_suffix #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `page_source_suffix` instead of checking `source_suffix` Since we now require sphinx 1.6 we can cleanup this old workaround for old sphinx versions.
stsewd
approved these changes
Mar 30, 2021
sdhiscocks
added a commit
to dstl/Stone-Soup
that referenced
this pull request
May 6, 2022
Reference change in: readthedocs/sphinx_rtd_theme#1104
awelzel
pushed a commit
to zeek/package-manager
that referenced
this pull request
Nov 3, 2023
These links 404'd because they omitted the file suffix, and they didn't really link to anything editable, just the raw file. --- In this case, "suffix" was used which is set by the readthedocs theme [1] in older versions [1]. Seem right to replace with page_source_suffix. [1] readthedocs/sphinx_rtd_theme#1104
awelzel
pushed a commit
to zeek/package-manager
that referenced
this pull request
Nov 3, 2023
These links 404'd because they omitted the file suffix, and they didn't really link to anything editable, just the raw file. --- In this case, "suffix" was used which is set by the readthedocs theme in older versions [1]. Seem good to replace with page_source_suffix. [1] readthedocs/sphinx_rtd_theme#1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
page_source_suffixinstead of checkingsource_suffixSince we now require sphinx 1.6 we can cleanup this old workaround for old sphinx versions.