From 4d8bf4813031e86e8a989906e6d30a857c6d1fe9 Mon Sep 17 00:00:00 2001
From: Joe Nelson <jonels@microsoft.com>
Date: Tue, 8 Jun 2021 16:22:36 -0500
Subject: [PATCH 1/3] Make version picker keyboard-controllable

---
 sphinx_rtd_theme/versions.html | 4 ++--
 src/sass/_theme_badge.sass     | 1 +
 src/theme.js                   | 6 ++++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/sphinx_rtd_theme/versions.html b/sphinx_rtd_theme/versions.html
index bab969e64..26e0d7c4e 100644
--- a/sphinx_rtd_theme/versions.html
+++ b/sphinx_rtd_theme/versions.html
@@ -1,11 +1,11 @@
 {% if READTHEDOCS %}
 {# Add rst-badge after rst-versions for small badge style. #}
   <div class="rst-versions" data-toggle="rst-versions" role="note" aria-label="{{ _('Versions') }}">
-    <span class="rst-current-version" data-toggle="rst-current-version">
+    <button class="rst-current-version" data-toggle="rst-current-version">
       <span class="fa fa-book"> Read the Docs</span>
       v: {{ current_version }}
       <span class="fa fa-caret-down"></span>
-    </span>
+    </button>
     <div class="rst-other-versions">
       <dl>
         <dt>{{ _('Versions') }}</dt>
diff --git a/src/sass/_theme_badge.sass b/src/sass/_theme_badge.sass
index b24ec10f4..92aaec635 100644
--- a/src/sass/_theme_badge.sass
+++ b/src/sass/_theme_badge.sass
@@ -20,6 +20,7 @@
     font-size: 90%
     cursor: pointer
     color: $green
+    width: 100%
     +clearfix
     .fa
       color: $section-background-color
diff --git a/src/theme.js b/src/theme.js
index 19778a41d..8683ec696 100644
--- a/src/theme.js
+++ b/src/theme.js
@@ -95,7 +95,13 @@ function ThemeNav () {
                 self.hashChange();
             })
             .on('click', "[data-toggle='rst-current-version']", function() {
+                var target = $(this);
                 $("[data-toggle='rst-versions']").toggleClass("shift-up");
+                target.attr(
+                    'aria-expanded',
+                    $("[data-toggle='rst-versions']").hasClass("shift-up") ?
+                        "true" : "false"
+                );
             })
 
         // Make tables responsive

From 3cbd4cfc5a047b309f5f1cbf21e4ae33f8f8bfb5 Mon Sep 17 00:00:00 2001
From: Joe Nelson <jonels@microsoft.com>
Date: Tue, 8 Jun 2021 17:52:07 -0500
Subject: [PATCH 2/3] Add aria-controls too

More information about the relation of elements on the page
---
 sphinx_rtd_theme/versions.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sphinx_rtd_theme/versions.html b/sphinx_rtd_theme/versions.html
index 26e0d7c4e..69379d4ef 100644
--- a/sphinx_rtd_theme/versions.html
+++ b/sphinx_rtd_theme/versions.html
@@ -1,12 +1,12 @@
 {% if READTHEDOCS %}
 {# Add rst-badge after rst-versions for small badge style. #}
   <div class="rst-versions" data-toggle="rst-versions" role="note" aria-label="{{ _('Versions') }}">
-    <button class="rst-current-version" data-toggle="rst-current-version">
+    <button class="rst-current-version" aria-expanded="false" aria-controls="docs_versions" data-toggle="rst-current-version">
       <span class="fa fa-book"> Read the Docs</span>
       v: {{ current_version }}
       <span class="fa fa-caret-down"></span>
     </button>
-    <div class="rst-other-versions">
+    <div class="rst-other-versions" id="docs_versions">
       <dl>
         <dt>{{ _('Versions') }}</dt>
         {% for slug, url in versions %}

From 50444583deae2231ef44a9573c6715512d55a27c Mon Sep 17 00:00:00 2001
From: Joe Nelson <jonels@microsoft.com>
Date: Fri, 11 Jun 2021 15:54:26 -0500
Subject: [PATCH 3/3] Update layout

---
 docs/_templates/layout.html | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/_templates/layout.html b/docs/_templates/layout.html
index 843122fd2..7f4034b39 100644
--- a/docs/_templates/layout.html
+++ b/docs/_templates/layout.html
@@ -11,12 +11,12 @@
 {%- block footer %}
   {%- if not READTHEDOCS %}
     <div class="rst-versions" data-toggle="rst-versions" role="note" aria-label="{{ _('Versions') }}">
-      <span class="rst-current-version" data-toggle="rst-current-version">
+      <button class="rst-current-version" aria-expanded="false" aria-controls="docs_versions" data-toggle="rst-current-version">
         <span class="fa fa-book"> Read the Docs</span>
         v: latest
         <span class="fa fa-caret-down"></span>
-      </span>
-      <div class="rst-other-versions">
+      </button>
+      <div class="rst-other-versions" id="docs_versions">
         <dl>
           <dt>{{ _('Versions') }}</dt>
           {%- if test_versions %}