Fix spacing issue with html4 output #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blendify
reviewed
Aug 12, 2021
Member
Blendify
left a comment
Blendify
left a comment
There was a problem hiding this comment.
For now this solution works, in the future we may want to remove the ul styles out of the section headings, I don't believe sphinx itself does this so there is a possibility that some styling might fail.
Collaborator
Author
|
I switched the approach in dde72c3, this seems to affect both html4 and html5 output positively. I don't get the bug in |
Collaborator
Author
|
I tested quickly with docutils 0.16 and 0.17 and both seemed fine. |
Blendify
approved these changes
Aug 13, 2021
The toctree wrapper can exist outside a section on html4 output. This resolve #1201, a bug introduced with docutils 0.17 support.
HTML5 still had the same issue with spacing.
agjohnson
force-pushed
the
agj/more-fix-docutils-17
branch
from
dde72c3 to
0850ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toctree wrapper can exist outside a section on html4 output. This
resolves some of the issues in #1201, namely a bug introduced with docutils 0.17 support.
This adds the missing margin back in:
It also protects against the edge case where toctree can be outside a section completely.
Edit: Nevermind, this does not fix the underlying bug completely, I'm noticing other spacing bugs
Edit edit: I think this does now fix #1201
Fixes #1201