Change search background

[CsatariGergely]

This pr adds the possibility to change the background
of the search area.

Signed-off-by: Gergely Csatari [email protected]

[davidfischer]

Is this the same as #404?

[Blendify]

Yes but a different approach.

[jessetan]

Assuming there won't be many of these style overrides, I like this approach more than the one in #404.

Two things I'm not certain on:

• Do we need to prefix this option with something like style_ so that we can group future style overrides, or do we think we will not have any more?
• This allows changing of the CSS background-color property. Would CSS background be a better choice so one can do background images or gradients as well?

[Blendify]

Assuming there won't be many of these style overrides, I like this approach more than the one in #404.

Two things I'm not certain on:

• Do we need to prefix this option with something like style_ so that we can group future style overrides, or do we think we will not have any more?
• This allows changing of the CSS background-color property. Would CSS background be a better choice so one can do background images or gradients as well?

1. Yes I think we should prefix this.
2. I think so, it gives more freedom.

[CsatariGergely]

Thanks for the suggestions @jessetan and @Blendify I've applied both of them.

[jessetan]

Code looks OK, just needs some documentation here: https://github.com/rtfd/sphinx_rtd_theme/blob/master/docs/configuring.rst#html-theme-options

[CsatariGergely]

@jessetan documentation is added.

[jessetan]

LGTM

[CsatariGergely]

What else is needed to merge this?

[CsatariGergely]

@ericholscher , @agjohnson can you please take a look please?

[ericholscher]

This feels oddly specific. Is there a reason we'd only support this one setting for a background color? It feels like having the theme be more overridable in general is a good goal, but this is a half measure. The comments on #404 touch on this, but having a full set of colors that can be overridden feels like the proper solution.

[ericholscher]

On second thought, this is a good approach for now, but we should do a larger rethink in #404.

[CsatariGergely]

Thanks @ericholscher . We can remove this approach once #404 is merged and use a more generic one.