RTL Support #986
Open
RTL Support #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've merged master into this PR. I think that we could probably just for this this PR and figure out user specified languages later. |
Author
|
@stsewd How can I help get this merged? |
Member
|
@AustinShalit thanks for the contribution, we need to wait for someone from the team with knowledge of CSS to review this. Sadly, I'm not that skilled with CSS to review this |
Member
|
I think if we are going to support rtl it should happen when we migrate to bootstrap. For now, I am going to say this changed in blocked by that decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291
Supersedes #498
498 grew stale and I wanted to revitalize it. This PR makes an improvement to that proposal: it uses a SASS mix-in instead of the dir pseudo-class. This means most browsers will support the change (dir is only supported on Firefox).
I need help understanding if there is a way to inject user properties into the sass. Specifically, I think it is important for the user to be able to specify the language codes in the list, which for now I have hard coded:
$rtl-languages: he, ar.