Enable async_without_await rule (#6104)

Author: SimplyDanny

.swiftlint.yml

@@ -16,7 +16,6 @@ opt_in_rules:
   - all
 disabled_rules:
   - anonymous_argument_in_multiline_closure
-  - async_without_await
   - conditional_returns_on_newline
   - contrasted_opening_brace
   - convenience_type

Plugins/SwiftLintBuildToolPlugin/SwiftLintBuildToolPlugin.swift

@@ -6,7 +6,7 @@ struct SwiftLintBuildToolPlugin: BuildToolPlugin {
     func createBuildCommands(
         context: PluginContext,
         target: Target
-    ) async throws -> [Command] {
+    ) throws -> [Command] {
         try makeCommand(executable: context.tool(named: "swiftlint"),
                         swiftFiles: (target as? SourceModuleTarget).flatMap(swiftFiles) ?? [],
                         environment: environment(context: context, target: target),

Source/SwiftLintFramework/Configuration+CommandLine.swift

@@ -75,8 +75,8 @@ private func autoreleasepool<T>(block: () -> T) -> T { block() }
 
 extension Configuration {
     func visitLintableFiles(with visitor: LintableFilesVisitor, storage: RuleStorage) async throws -> [SwiftLintFile] {
-        let files = try await Signposts.record(name: "Configuration.VisitLintableFiles.GetFiles") {
-            try await getFiles(with: visitor)
+        let files = try Signposts.record(name: "Configuration.VisitLintableFiles.GetFiles") {
+            try getFiles(with: visitor)
         }
         let groupedFiles = try Signposts.record(name: "Configuration.VisitLintableFiles.GroupFiles") {
             try groupFiles(files, visitor: visitor)
@@ -236,7 +236,7 @@ extension Configuration {
             linters.asyncMap(visit)
     }
 
-    fileprivate func getFiles(with visitor: LintableFilesVisitor) async throws -> [SwiftLintFile] {
+    fileprivate func getFiles(with visitor: LintableFilesVisitor) throws -> [SwiftLintFile] {
         let options = visitor.options
         if options.useSTDIN {
             let stdinData = FileHandle.standardInput.readDataToEndOfFile()

Source/swiftlint-dev/Reporters+Register.swift

@@ -18,7 +18,7 @@ extension SwiftLintDev.Reporters {
                 .appendingPathComponent("Reporters", isDirectory: true)
         }
 
-        func run() async throws {
+        func run() throws {
             guard FileManager.default.fileExists(atPath: reportersDirectory.path) else {
                 throw ValidationError("Command must be run from the root of the SwiftLint repository.")
             }

Source/swiftlint-dev/Rules+Register.swift

@@ -26,7 +26,7 @@ extension SwiftLintDev.Rules {
                 .appendingPathComponent("GeneratedTests", isDirectory: true)
         }
 
-        func run() async throws {
+        func run() throws {
             try runFor(newRule: nil)
         }
 

Source/swiftlint-dev/Rules+Template.swift

@@ -42,7 +42,7 @@ extension SwiftLintDev.Rules {
         @Flag(name: .long, help: "Skip registration.")
         var skipRegistration = false
 
-        func run() async throws {
+        func run() throws {
             let rootDirectory = URL(fileURLWithPath: FileManager.default.currentDirectoryPath)
             let ruleDirectory = rootDirectory
                 .appendingPathComponent("Source", isDirectory: true)