Skip to content

Report remaining fixed and new violations #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Report remaining fixed and new violations #6140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tools/oss-check
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ def diff_and_report_changes_to_danger
severity_changed = []
rule_id_changed = []
column_changed = []
remaining_violations = []

new_violations.each do |line|
fixed = fixed_violations.find { |other| line.equal_to?(other, [:message]) }
Expand All @@ -315,8 +316,11 @@ def diff_and_report_changes_to_danger
if fixed
next column_changed << Change.new(:column, line, fixed)
end
remaining_violations << line
end

remaining_fixed = fixed_violations - (message_changed + severity_changed + rule_id_changed + column_changed).map(&:old)

# Print new and fixed violations to be processed by Danger.
new_violations.each { |line|
warn "This PR introduced a violation in #{repo.name}: #{line.to_full_message_with_linked_path(repo)}"
Expand Down Expand Up @@ -346,13 +350,13 @@ def diff_and_report_changes_to_danger
summary.puts
column_changed.each { |change| change.print_as_diff(repo, summary) }
summary.puts
summary.puts "### Fixed violations (#{fixed_violations.count})"
summary.puts "### Other fixed violations (#{remaining_fixed.count})"
summary.puts
fixed_violations.each { |violation| summary.puts "- #{violation.to_full_message_with_linked_path(repo)}" }
remaining_fixed.each { |violation| summary.puts "- #{violation.to_full_message_with_linked_path(repo)}" }
summary.puts
summary.puts "### New violations (#{new_violations.count})"
summary.puts "### Other new violations (#{remaining_violations.count})"
summary.puts
new_violations.each { |violation| summary.puts "- #{violation.to_full_message_with_linked_path(repo)}" }
remaining_violations.each { |violation| summary.puts "- #{violation.to_full_message_with_linked_path(repo)}" }
summary.puts

summary.string
Expand Down
Loading