RCORE-2120 Throw useful error messages if baasaas fails to start a container (#7480)

Author: jbreams

test/object-store/util/sync/baas_admin_api.cpp

@@ -277,6 +277,8 @@ std::string_view getenv_sv(const char* name) noexcept
     return {};
 }
 
+const static std::string g_baas_coid_header_name("x-appservices-request-id");
+
 } // namespace
 
 app::Response do_http_request(const app::Request& request)
@@ -354,7 +356,7 @@ app::Response do_http_request(const app::Request& request)
     }
     if (logger->would_log(util::Logger::Level::trace)) {
         std::string coid = [&] {
-            auto coid_header = response_headers.find("X-Appservices-Request-Id");
+            auto coid_header = response_headers.find(g_baas_coid_header_name);
             if (coid_header == response_headers.end()) {
                 return std::string{};
             }
@@ -401,8 +403,21 @@ class Baasaas {
             logger->info("Starting baasaas container");
         }
 
-        auto resp = do_request(std::move(url_path), app::HttpMethod::post);
+        auto [resp, baas_coid] = do_request(std::move(url_path), app::HttpMethod::post);
+        if (!resp["id"].is_string()) {
+            throw RuntimeError(
+                ErrorCodes::RuntimeError,
+                util::format(
+                    "Failed to start baas container, got response without container ID: \"%1\" (baas coid: %2)",
+                    resp.dump(), baas_coid));
+        }
         m_container_id = resp["id"].get<std::string>();
+        if (m_container_id.empty()) {
+            throw RuntimeError(
+                ErrorCodes::InvalidArgument,
+                util::format("Failed to start baas container, got response with empty container ID (baas coid: %1)",
+                             baas_coid));
+        }
         logger->info("Baasaas container started with id \"%1\"", m_container_id);
         auto lock_file = util::File(std::string{s_baasaas_lock_file_name}, util::File::mode_Write);
         lock_file.write(m_container_id);
@@ -442,9 +457,15 @@ class Baasaas {
         while (std::chrono::system_clock::now() - poll_start_at < std::chrono::minutes(2) &&
                m_http_endpoint.empty()) {
             if (http_endpoint.empty()) {
-                auto status_obj =
+                auto [status_obj, baas_coid] =
                     do_request(util::format("containerStatus?id=%1", m_container_id), app::HttpMethod::get);
                 if (!status_obj["httpUrl"].is_null()) {
+                    if (!status_obj["httpUrl"].is_string() || !status_obj["mongoUrl"].is_string()) {
+                        throw RuntimeError(ErrorCodes::RuntimeError,
+                                           util::format("Error polling for baasaas instance. httpUrl or mongoUrl is "
+                                                        "the wrong format: \"%1\" (baas coid: %2)",
+                                                        status_obj.dump(), baas_coid));
+                    }
                     http_endpoint = status_obj["httpUrl"].get<std::string>();
                     mongo_endpoint = status_obj["mongoUrl"].get<std::string>();
                 }
@@ -507,7 +528,7 @@ class Baasaas {
     }
 
 private:
-    nlohmann::json do_request(std::string api_path, app::HttpMethod method)
+    std::pair<nlohmann::json, std::string> do_request(std::string api_path, app::HttpMethod method)
     {
         app::Request request;
 
@@ -516,10 +537,29 @@ class Baasaas {
         request.headers.insert_or_assign("apiKey", m_api_key);
         request.headers.insert_or_assign("Content-Type", "application/json");
         auto response = do_http_request(request);
-        REALM_ASSERT_EX(response.http_status_code >= 200 && response.http_status_code < 300,
-                        util::format("Baasaas api response code: %1 Response body: %2", response.http_status_code,
-                                     response.body));
-        return nlohmann::json::parse(response.body);
+        if (response.http_status_code < 200 || response.http_status_code >= 300) {
+            throw RuntimeError(ErrorCodes::HTTPError,
+                               util::format("Baasaas api response code: %1 Response body: %2, Baas coid: %3",
+                                            response.http_status_code, response.body,
+                                            baas_coid_from_response(response)));
+        }
+        try {
+            return {nlohmann::json::parse(response.body), baas_coid_from_response(response)};
+        }
+        catch (const nlohmann::json::exception& e) {
+            throw RuntimeError(
+                ErrorCodes::MalformedJson,
+                util::format("Error making baasaas request to %1 (baas coid %2): Invalid json returned \"%3\" (%4)",
+                             request.url, baas_coid_from_response(response), response.body, e.what()));
+        }
+    }
+
+    std::string baas_coid_from_response(const app::Response& resp)
+    {
+        if (auto it = resp.headers.find(g_baas_coid_header_name); it != resp.headers.end()) {
+            return it->second;
+        }
+        return "<not found>";
     }
 
     static std::string get_baasaas_base_url()