Use the "clang-format" provided by the system (#7554)

kraenhansen · web-flow · commit 2e9cee0ed703 · 2024-04-04T23:50:31.000+02:00
* Use the "clang-format" provided by the system

* Adding a note to the changelog
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@
 * Recreating the sync metadata Realm when the encryption key changes is now done in a multi-process safe manner ([PR #7526](https://github.com/realm/realm-core/pull/7526)).
 * Added `App::default_base_url()` static accessor for SDKs to retrieve the default base URL from Core. ([PR #7534](https://github.com/realm/realm-core/pull/7534))
 * Realm2JSON tool will now correctly upgrade file to current fileformat.
+* (bindgen) Remove dependency on the `clang-format` package and rely on a binary provided by the system instead.
 
 ----------------------------------------------
 
diff --git a/bindgen/src/formatter.ts b/bindgen/src/formatter.ts
@@ -67,4 +67,4 @@ export function format(formatter: Formatter, cwd: string, filePaths: string[]):
   }
 }
 
-export const clangFormat = createCommandFormatter("clang", ["npx", "clang-format", "-i"]);
+export const clangFormat = createCommandFormatter("clang", ["clang-format", "-i"]);
diff --git a/package.json b/package.json
@@ -22,7 +22,6 @@
     "chalk": "^4.1.2",
     "change-case": "^4.1.2",
     "chevrotain": "^10.4.0",
-    "clang-format": "^1.8.0",
     "commander": "^11.1.0",
     "debug": "^4.3.4",
     "typescript-json-schema": "^0.55.0",

Original file line number	Diff line number	Diff line change
`@@ -67,4 +67,4 @@ export function format(formatter: Formatter, cwd: string, filePaths: string[]):`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`70`		`-export const clangFormat = createCommandFormatter("clang", ["npx", "clang-format", "-i"]);`
	`70`	`+export const clangFormat = createCommandFormatter("clang", ["clang-format", "-i"]);`