Fix some compiler warnings (#7531)

Author: jedelbo

src/realm/collection_parent.cpp

@@ -75,13 +75,13 @@ CollectionParent::~CollectionParent() {}
 
 void CollectionParent::check_level() const
 {
-    if (m_level + 1 > s_max_level) {
+    if (size_t(m_level) + 1 > s_max_level) {
         throw LogicError(ErrorCodes::LimitExceeded, "Max nesting level reached");
     }
 }
 
 template <typename Base, template <typename> typename Collection, typename LinkCol>
-std::unique_ptr<Base> create_collection(ColKey col_key, size_t level)
+std::unique_ptr<Base> create_collection(ColKey col_key, uint8_t level)
 {
     bool nullable = col_key.get_attrs().test(col_attr_Nullable);
     switch (col_key.get_type()) {
@@ -128,19 +128,19 @@ std::unique_ptr<Base> create_collection(ColKey col_key, size_t level)
     }
 }
 
-LstBasePtr CollectionParent::get_listbase_ptr(ColKey col_key, size_t level)
+LstBasePtr CollectionParent::get_listbase_ptr(ColKey col_key, uint8_t level)
 {
     REALM_ASSERT(col_key.get_attrs().test(col_attr_List) || col_key.get_type() == col_type_Mixed);
     return create_collection<LstBase, Lst, LnkLst>(col_key, level);
 }
 
-SetBasePtr CollectionParent::get_setbase_ptr(ColKey col_key, size_t level)
+SetBasePtr CollectionParent::get_setbase_ptr(ColKey col_key, uint8_t level)
 {
     REALM_ASSERT(col_key.get_attrs().test(col_attr_Set));
     return create_collection<SetBase, Set, LnkSet>(col_key, level);
 }
 
-CollectionBasePtr CollectionParent::get_collection_ptr(ColKey col_key, size_t level)
+CollectionBasePtr CollectionParent::get_collection_ptr(ColKey col_key, uint8_t level)
 {
     if (col_key.is_list()) {
         return get_listbase_ptr(col_key, level);

src/realm/collection_parent.hpp

@@ -99,9 +99,9 @@ class CollectionParent : public std::enable_shared_from_this<CollectionParent> {
     // a write to mark the already up-to-date parent as still being up-to-date.
     virtual void update_content_version() const noexcept = 0;
 
-    static LstBasePtr get_listbase_ptr(ColKey col_key, size_t level);
-    static SetBasePtr get_setbase_ptr(ColKey col_key, size_t level);
-    static CollectionBasePtr get_collection_ptr(ColKey col_key, size_t level);
+    static LstBasePtr get_listbase_ptr(ColKey col_key, uint8_t level);
+    static SetBasePtr get_setbase_ptr(ColKey col_key, uint8_t level);
+    static CollectionBasePtr get_collection_ptr(ColKey col_key, uint8_t level);
 
     static int64_t generate_key(size_t sz);
     static void set_key(BPlusTreeMixed& tree, size_t index);

src/realm/dictionary.cpp

@@ -48,7 +48,7 @@ void validate_key_value(const Mixed& key)
 
 /******************************** Dictionary *********************************/
 
-Dictionary::Dictionary(ColKey col_key, size_t level)
+Dictionary::Dictionary(ColKey col_key, uint8_t level)
     : Base(col_key)
     , CollectionParent(level)
 {

src/realm/dictionary.hpp

@@ -51,7 +51,7 @@ class Dictionary final : public CollectionBaseImpl<DictionaryBase>, public Colle
         : Base(parent, index)
     {
     }
-    Dictionary(ColKey col_key, size_t level = 1);
+    Dictionary(ColKey col_key, uint8_t level = 1);
     Dictionary(const Dictionary& other)
         : Base(static_cast<const Base&>(other))
         , CollectionParent(other.get_level())

src/realm/list.hpp

@@ -291,7 +291,7 @@ class Lst<Mixed> final : public CollectionBaseImpl<LstBase>, public CollectionPa
     {
         this->set_owner(owner, col_key);
     }
-    Lst(ColKey col_key, size_t level = 1)
+    Lst(ColKey col_key, uint8_t level = 1)
         : Base(col_key)
         , CollectionParent(level)
     {

src/realm/sync/client.cpp

@@ -1937,7 +1937,8 @@ void SessionWrapper::report_progress(bool is_download, bool only_if_new_uploadab
         p.downloadable = p.downloaded;
         if (0.01 <= download_estimate && download_estimate <= 0.99)
             if (p.downloaded > p.final_downloaded)
-                p.downloadable = p.final_downloaded + (p.downloaded - p.final_downloaded) / download_estimate;
+                p.downloadable =
+                    p.final_downloaded + uint64_t((p.downloaded - p.final_downloaded) / download_estimate);
     }
     else {
         if (!is_completed || !is_download)