Fix ErrorStorage initialization of private fields

Author: blagoev

src/realm/object-store/c_api/error.cpp

@@ -15,6 +15,8 @@ namespace realm::c_api {
 ErrorStorage::ErrorStorage(std::exception_ptr ptr) noexcept
     : m_err(none)
     , m_message_buf()
+    , m_usercode_error(nullptr)
+    
 {
     printf("ErrorStorage::ErrorStorage(std::exception_ptr ptr) noexcept\n");
     assign(std::move(ptr));
@@ -23,6 +25,7 @@ ErrorStorage::ErrorStorage(std::exception_ptr ptr) noexcept
 ErrorStorage::ErrorStorage(const ErrorStorage& other)
     : m_err(other.m_err)
     , m_message_buf(other.m_message_buf)
+    , m_usercode_error(other.m_usercode_error)
 {
     printf("ErrorStorage::ErrorStorage(const ErrorStorage& other)\n");
     if (m_err) {
@@ -35,6 +38,7 @@ ErrorStorage& ErrorStorage::operator=(const ErrorStorage& other)
     printf("ErrorStorage& ErrorStorage::operator=(const ErrorStorage& other)\n");
     m_err = other.m_err;
     m_message_buf = other.m_message_buf;
+    m_usercode_error = other.m_usercode_error;
     if (m_err) {
         m_err->message = m_message_buf.c_str();
     }
@@ -44,6 +48,7 @@ ErrorStorage& ErrorStorage::operator=(const ErrorStorage& other)
 ErrorStorage::ErrorStorage(ErrorStorage&& other)
     : m_err(std::move(other.m_err))
     , m_message_buf(std::move(other.m_message_buf))
+    , m_usercode_error(std::move(other.m_usercode_error))
 {
     printf("ErrorStorage::ErrorStorage(ErrorStorage&& other)\n");
     if (m_err) {
@@ -57,6 +62,7 @@ ErrorStorage& ErrorStorage::operator=(ErrorStorage&& other)
     printf("ErrorStorage& ErrorStorage::operator=(ErrorStorage&& other)\n");
     m_err = std::move(other.m_err);
     m_message_buf = std::move(other.m_message_buf);
+    m_usercode_error = std::move(other.m_usercode_error);
     if (m_err) {
         m_err->message = m_message_buf.c_str();
     }
@@ -72,7 +78,7 @@ bool ErrorStorage::operator==(const ErrorStorage& other) const noexcept
     else if (!m_err && !other.m_err) {
         return true;
     }
-    return m_err->error == other.m_err->error && m_message_buf == other.m_message_buf;
+    return m_err->error == other.m_err->error && m_message_buf == other.m_message_buf; // && m_usercode_error == other.m_usercode_error; //TODO: should we compare the usercode_error here 
 }
 
 void ErrorStorage::assign(std::exception_ptr eptr) noexcept