Merge branch 'master' of github.com:realm/realm-core into next-major

Author: nicola-cab

.github/workflows/make-release.yml

@@ -0,0 +1,68 @@
+name: "Make Release"
+
+# This runs automatically after a release PR is merged
+# See github.com/realm/realm-core/doc/development/how-to-release.md
+
+on:
+  pull_request:
+    types:
+      - closed
+
+jobs:
+  finish_release:
+    if: github.event.pull_request.merged == true && startsWith(github.head_ref, 'release/automated_v')
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+      with:
+        submodules: false
+    - name: Read version
+      id: get-version
+      run: |
+        realm_version=$(sed -rn 's/^VERSION: (.*)/\1/p' < "dependencies.yml")
+        echo "version=$realm_version" >> $GITHUB_OUTPUT
+      shell: bash
+    - name: Extract Release Notes Section
+      run: |
+        awk '/^#.*Release notes/{if(++i>1)exit} i' CHANGELOG.md > extracted_changelog.md
+      shell: bash
+    - name: Make Tag and Publish Github Release
+      uses: ncipollo/release-action@2c591bcc8ecdcd2db72b97d6147f871fcd833ba5 #! 1.14.0
+      with:
+        bodyFile: extracted_changelog.md
+        name: ${{ steps.get-version.outputs.version }}
+        commit: ${{ github.base_ref }}
+        tag: ${{ steps.get-version.outputs.version }}
+        token: ${{ secrets.GITHUB_TOKEN }}
+        draft: false
+    - name: Update Changelog
+      run: |
+        cat "doc/CHANGELOG_template.md" "CHANGELOG.md" > temp_file.md; mv temp_file.md "CHANGELOG.md"
+      shell: bash
+    - name: Create vNext PR
+      id: vnext-pr
+      uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e #! 6.0.5
+      with:
+        branch: prepare-vnext
+        title: Prepare for vNext
+        body: Update Changelog for vNext
+        delete-branch: true
+        draft: false
+        base: ${{ github.base_ref }}
+        labels: no-jira-ticket
+        add-paths: CHANGELOG.md
+        commit-message: New changelog section to prepare for vNext
+    - name: Merge Pull Request
+      uses: juliangruber/merge-pull-request-action@9234b8714dda9a08f3d1df5b2a6a3abd7b695353 #! 1.3.1
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        number: ${{ steps.vnext-pr.outputs.pull-request-number }}
+        method: squash
+    - name: 'Post to #appx-releases'
+      uses: realm/ci-actions/release-to-slack@fa20eb972b9f018654fdb4e2c7afb52b0532f907
+      with:
+        changelog: extracted_changelog.md
+        sdk: Core
+        webhook-url: ${{ secrets.SLACK_RELEASE_WEBHOOK }}
+        version: ${{ steps.get-version.outputs.version }}

.github/workflows/prepare-release.yml

@@ -0,0 +1,39 @@
+name: Prepare Release
+
+# This action is triggered manually and starts the release process.
+# See github.com/realm/realm-core/doc/development/how-to-release.md
+
+on:
+  workflow_dispatch:
+    inputs:
+      version:
+        description: Use this to provide a version. For example "10.123.1" or "4.5.0-CustDemo".
+        required: true
+        type: string
+
+jobs:
+  main:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+        with:
+          submodules: false
+          fetch-depth: 0 # include history and tags
+      - name: Change Version
+        run: tools/release-init.sh ${{ inputs.version }}
+        shell: bash
+      - name: Create Release PR
+        uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e #! 6.0.5
+        with:
+          branch: release/automated_v${{ inputs.version }}
+          title: Prepare for ${{ inputs.version }}
+          draft: false
+          body-path: changes-since-last-tag.txt
+          labels: no-jira-ticket
+          commit-message: Prepare for release ${{ inputs.version }}
+          token: ${{ secrets.REALM_CI_PAT }}
+          add-paths: |
+            dependencies.yml
+            Package.swift
+            CHANGELOG.md

.gitignore

@@ -107,3 +107,7 @@ tsconfig.tsbuildinfo
 # Baas remote host artifacts
 baas-work-dir/
 ssh_agent_commands.sh
+
+# release script artifacts
+extracted_changelog.md
+changes-since-last-tag.txt

Android.bp

@@ -75,6 +75,7 @@ cc_object {
         "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid128_string.c",
         "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid128_2_str_tables.c",
         "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid64_to_bid128.c",
+        "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid32_to_bid128.c",
         "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid128_to_int64.c",
         "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid128_quantize.c",
         "src/external/IntelRDFPMathLib20U2/LIBRARY/src/bid_convert_data.c",

CHANGELOG.md

@@ -1,11 +1,10 @@
-# NEXT MAJOR RELEASE
+# NEXT RELEASE
 
 ### Enhancements
 * <New feature description> (PR [#????](https://github.com/realm/realm-core/pull/????))
 
 ### Fixed
 * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
-* None.
 
 ### Breaking changes
 * None.
@@ -20,6 +19,28 @@
 
 ----------------------------------------------
 
+# 14.8.0 Release notes
+
+### Enhancements
+* Add vendor support to the Android Blueprint (PR [#7614](https://github.com/realm/realm-core/pull/7614)).
+
+### Fixed
+* A non-streaming progress notifier would not immediately call its callback after registration. Instead you would have to wait for a download message to be received to get your first update - if you were already caught up when you registered the notifier you could end up waiting a long time for the server to deliver a download that would call/expire your notifier ([#7627](https://github.com/realm/realm-core/issues/7627), since v14.6.0).
+* Comparing a numeric property with an argument list containing a string would throw. ([#7714](https://github.com/realm/realm-core/issues/7714), since v14.7.0)
+
+### Breaking changes
+* None.
+
+### Compatibility
+* Fileformat: Generates files with format v24. Reads and automatically upgrade from fileformat v10. If you want to upgrade from an earlier file format version you will have to use RealmCore v13.x.y or earlier.
+
+-----------
+
+### Internals
+* `util::Thread` no longer has any functionality other than `get_name()` and `set_name()`. Use `std::thread` instead ([PR #7696](https://github.com/realm/realm-core/pull/7696)).
+
+----------------------------------------------
+
 # 14.7.0 Release notes
 
 ### Enhancements
@@ -68,6 +89,8 @@
 * None.
 
 ### Fixed
+* Fix assertion failure or wrong results when evaluating a RQL query with multiple IN conditions on the same property. Applies to non-indexed int/string/ObjectId/UUID properties, or if they were indexed and had > 100 conditions. ((RCORE-2098) [PR #7628](https://github.com/realm/realm-core/pull/7628) since v14.6.0).
+* Fixed a bug when running a IN query (or a query of the pattern `x == 1 OR x == 2 OR x == 3`) when evaluating on a string property with an empty string in the search condition. Matches with an empty string would have been evaluated as if searching for a null string instead. ([PR #7628](https://github.com/realm/realm-core/pull/7628) since v10.0.0-beta.9)
 
 ### Breaking changes
 * None.
@@ -78,7 +101,10 @@
 -----------
 
 ### Internals
-* None.
+* Follow on to ([PR #7300](https://github.com/realm/realm-core/pull/7300)) to allow SDKs to construct a fake user for testing SyncManager::get_user -> App::create_fake_user_for_testing ([PR #7632](https://github.com/realm/realm-core/pull/7632))
+* Fix build-apple-device.sh, broken in [#7603](https://github.com/realm/realm-core/pull/7603) ([PR #7640](https://github.com/realm/realm-core/pull/7640)).
+* Added a CAPI interface for SDKs to bring their own managed users with core's app services turned off. ([PR #7615](https://github.com/realm/realm-core/pull/7615)).
+* Bump the minimum deployment targets on Apple platforms to the minimums supported by Xcode 15 and clean up now unused availability checks. ([PR #7648](https://github.com/realm/realm-core/pull/7648)).
 * Build with -Werror on CI to ensure that new warnings don't slip in. ([PR #7646](https://github.com/realm/realm-core/pull/7646))
 
 ----------------------------------------------
@@ -200,6 +226,7 @@
 * Added `App::default_base_url()` static accessor for SDKs to retrieve the default base URL from Core. ([PR #7534](https://github.com/realm/realm-core/pull/7534))
 * Realm2JSON tool will now correctly upgrade file to current fileformat.
 * (bindgen) Remove dependency on the `clang-format` package and rely on a binary provided by the system instead.
+* Protocol version bumped to 12 ([#7124](https://github.com/realm/realm-core/issues/7124))
 
 ----------------------------------------------
 
@@ -341,7 +368,7 @@
 # 14.0.0 Release notes
 
 ### Enhancements
-* Property keypath in RQL can be substituted with value given as argument. Use '$P<i>' in query string. (Issue [#7033](https://github.com/realm/realm-core/issues/7033))
+* Property keypath in RQL can be substituted with value given as argument. Use '$K\<i\>' in query string. (Issue [#7033](https://github.com/realm/realm-core/issues/7033))
 * You can now use query substitution for the @type argument ([#7289](https://github.com/realm/realm-core/issues/7289))
 
 ### Fixed
@@ -3230,7 +3257,6 @@
 * Added `TableView::update_query()`
 
 ### Fixed
-* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
 * Fix race potentially allowing frozen transactions to access incomplete search index accessors. (Since v6)
 * Fix queries for null on non-nullable indexed integer columns returning results for zero entries. (Since v6)
 * Fix queries for null on a indexed ObjectId column returning results for the zero ObjectId. (Since v10)

Package.swift

@@ -3,7 +3,7 @@
 import PackageDescription
 import Foundation
 
-let versionStr = "14.7.0"
+let versionStr = "14.8.0"
 let versionPieces = versionStr.split(separator: "-")
 let versionCompontents = versionPieces[0].split(separator: ".")
 let versionExtra = versionPieces.count > 1 ? versionPieces[1] : ""

dependencies.yml

@@ -1,5 +1,5 @@
 PACKAGE_NAME: realm-core
-VERSION: 14.7.0
+VERSION: 14.8.0
 OPENSSL_VERSION: 3.2.0
 ZLIB_VERSION: 1.2.13
 # https://github.com/10gen/baas/commits

doc/development/how-to-release.md

@@ -0,0 +1,17 @@
+The core release process is automated with github [actions](https://github.com/realm/realm-core/actions)
+
+1. Run the prepare-release action.
+  - input the base branch that you would like to make a release from (usually this will be "master").
+  - input the release version (eg. "10.14.7")
+
+2. This will create a PR, which you should look over and get someone else on the team to review. Verify the changelog by checking the PR description which has a list of commits since the last tag was made. If any changes are required, commit them to this PR's branch.
+
+3. When ready, merge the PR. You can squash if there are only "prepare release" changes, but use a "merge-commit" strategy if there are functional changes added manually to the PR. On merge, the "make-release" action will run. This takes care of:
+  - Making a tag
+  - Publishing the release on Github
+  - Updating the Changelog
+  - Announcing the release in the #appx-releases slack channel
+
+## Previous process
+
+The previous release notes documentation can be found on the old Realm wiki https://github.com/realm/realm-wiki/wiki/Releasing-Realm-Core

src/realm/list.cpp

@@ -136,7 +136,7 @@ void CollectionBaseImpl<LstBase>::to_json(std::ostream& out, JSONOutputMode outp
         if (i > 0)
             out << ",";
         Mixed val = get_any(i);
-        if (val.is_type(type_TypedLink)) {
+        if (val.is_type(type_Link, type_TypedLink)) {
             fn(val);
         }
         else {
@@ -951,19 +951,9 @@ void LnkLst::remove_all_target_rows()
     }
 }
 
-void LnkLst::to_json(std::ostream& out, JSONOutputMode, util::FunctionRef<void(const Mixed&)> fn) const
+void LnkLst::to_json(std::ostream& out, JSONOutputMode mode, util::FunctionRef<void(const Mixed&)> fn) const
 {
-    out << "[";
-
-    auto sz = m_list.size();
-    for (size_t i = 0; i < sz; i++) {
-        if (i > 0)
-            out << ",";
-        Mixed val(m_list.get(i));
-        fn(val);
-    }
-
-    out << "]";
+    m_list.to_json(out, mode, fn);
 }
 
 void LnkLst::replace_link(ObjKey old_val, ObjKey new_val)

src/realm/object-store/util/scheduler.cpp

@@ -37,7 +37,7 @@
 #define HAS_ANDROID_ALOOPER
 #endif
 
-#if HAS_ANDROID_ALOOPER
+#if defined(HAS_ANDROID_ALOOPER)
 #include <realm/object-store/util/android/scheduler.hpp>
 #endif
 
@@ -134,7 +134,7 @@ std::shared_ptr<Scheduler> Scheduler::make_platform_default()
 #else
 #if REALM_PLATFORM_APPLE
     return make_runloop(nullptr);
-#elif HAS_ANDROID_ALOOPER
+#elif defined(HAS_ANDROID_ALOOPER)
     return make_alooper();
 #elif defined(__EMSCRIPTEN__)
     return std::make_shared<EmscriptenScheduler>();
@@ -176,7 +176,7 @@ std::shared_ptr<Scheduler> Scheduler::make_dispatch(void* queue)
 }
 #endif // REALM_PLATFORM_APPLE
 
-#if HAS_ANDROID_ALOOPER
+#if defined(HAS_ANDROID_ALOOPER)
 std::shared_ptr<Scheduler> Scheduler::make_alooper()
 {
     return std::make_shared<ALooperScheduler>();