Fix a data race in a test

Author: tgoyne

src/realm/object-store/sync/sync_session.cpp

@@ -740,7 +740,7 @@ void SyncSession::handle_error(sync::SessionErrorInfo error)
         return;
     }
 
-    // Dont't bother invoking m_config.error_handler if the sync is inactive.
+    // Don't bother invoking m_config.error_handler if the sync is inactive.
     // It does not make sense to call the handler when the session is closed.
     if (m_state == State::Inactive || m_state == State::Paused) {
         return;

test/object-store/sync/flx_sync.cpp

@@ -612,7 +612,8 @@ TEST_CASE("flx: client reset", "[sync][flx][client reset][baas]") {
         util::try_remove_dir_recursive(fresh_path);
 
         auto config_copy = config_local;
-        config_local.sync_config->error_handler = nullptr;
+        config_copy.sync_config = std::make_shared<SyncConfig>(*config_copy.sync_config);
+        config_copy.sync_config->error_handler = nullptr;
         auto&& [reset_future, reset_handler] = make_client_reset_handler();
         config_copy.sync_config->notify_after_client_reset = reset_handler;