RDART-1018: Fix badly generated _fromJson (#1664)

* Fix badly generated _fromJson

* Update CHANGELOG

Author: Kasper Overgård Nielsen

CHANGELOG.md

@@ -4,7 +4,7 @@
 * None
 
 ### Fixed
-* None
+* Private fields did not work with default values. (Issue [#1663](https://github.com/realm/realm-dart/issues/1663))
 
 ### Compatibility
 * Realm Studio: 15.0.0 or later.

packages/realm_generator/lib/src/realm_model_info.dart

@@ -146,7 +146,7 @@ class RealmModelInfo {
           yield '} => $name(';
           {
             yield* positional.map((f) => 'fromEJson(${f.name}),');
-            yield* named.map((f) => '${f.name}: fromEJson(${f.name}),');
+            yield* named.map((f) => '${paramName(f)}: fromEJson(${f.name}),');
           }
           yield '),';
           yield '_ => raiseInvalidEJson(ejson),';

packages/realm_generator/test/good_test_data/private_fields.expected

@@ -66,7 +66,7 @@ class WithPrivateFields extends _WithPrivateFields
       } =>
         WithPrivateFields(
           fromEJson(_plain),
-          _withDefault: fromEJson(_withDefault),
+          withDefault: fromEJson(_withDefault),
         ),
       _ => raiseInvalidEJson(ejson),
     };