RDART-1031: Disable codesign for apple binaries (#1694)

* Disable codesign for apple binaries

* Set signing_allowed = no in cmakelists instead

* Move comment to the right place

Author: nirinchev

CHANGELOG.md

@@ -4,13 +4,14 @@
 * None
 
 ### Fixed
-* None
+* Fixed an issue that would cause macOS apps to be rejected with `Invalid Code Signing Entitlements` error. (Issue [#1679](https://github.com/realm/realm-dart/issues/1679))
 
 ### Compatibility
 * Realm Studio: 15.0.0 or later.
 
 ### Internal
-* Using Core x.y.z.
+* Using Core 14.7.0.
+* Disabled codesigning of Apple binaries. (Issue [#1679](https://github.com/realm/realm-dart/issues/1679))
 
 ## 2.3.0 (2024-05-23)
 

packages/realm_dart/CMakeLists.txt

@@ -14,9 +14,9 @@ if("$ENV{REALM_USE_CCACHE}" STREQUAL "TRUE")
     include(src/realm.build.use.ccache.cmake)
 endif()
 
-message ("Realm Dart")
-message ("CMAKE_BINARY_DIR is ${CMAKE_BINARY_DIR}")
-message ("PROJECT_SOURCE_DIR is ${PROJECT_SOURCE_DIR}")
+message("Realm Dart")
+message("CMAKE_BINARY_DIR is ${CMAKE_BINARY_DIR}")
+message("PROJECT_SOURCE_DIR is ${PROJECT_SOURCE_DIR}")
 
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED on)
@@ -36,6 +36,13 @@ if(CMAKE_SYSTEM_NAME MATCHES "^Windows")
     )
 endif()
 
+if(APPLE)
+    # TODO: allow code signing once we setup certificates on CI.
+    # Otherwise, Xcode 15 will use an empty identifier, which will then be rejected when the app is submitted to the app store.
+    # See https://github.com/realm/realm-dart/issues/1679 for more details.
+    set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_ALLOWED NO)
+endif()
+
 set(_SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING=1)
 
 add_subdirectory(src)