Skip to content

Commit e2d9187

Browse files
Kasper Overgård Nielsennirinchev
andauthored
RDART-962: Use xcode 15.4 (#1548)
* Use xcode 15.4 Update CHANGELOG Use Release instead of MinSIzeRel * bump ulimit on ios test * Check arch instead of inferring implicitly * Update flutter-desktop-tests.yml to match dart-desktop-tests.yml * Don't force XCode version on iOS tests (only on builds) * Run iOS test on macos-12 * Update CHANGELOG * PR feedback Co-authored-by: Nikola Irinchev <[email protected]> * PR feedback 2 --------- Co-authored-by: Nikola Irinchev <[email protected]>
1 parent 413e21a commit e2d9187

File tree

8 files changed

+127
-83
lines changed

8 files changed

+127
-83
lines changed

.github/workflows/binary-combine-android.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ jobs:
1414
with:
1515
name: librealm-android-x86_64
1616
path: packages/realm_dart/binary/android
17+
1718
- name: Fetch armeabi-v7a build
1819
uses: actions/download-artifact@v4
1920
with:
2021
name: librealm-android-armeabi-v7a
2122
path: packages/realm_dart/binary/android
23+
2224
- name: Fetch arm64-v8a build
2325
uses: actions/download-artifact@v4
2426
with:

.github/workflows/build-native.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,11 @@ jobs:
5151
if: startsWith(matrix.build, 'android')
5252
run: echo "ANDROID_NDK=$ANDROID_NDK_LATEST_HOME" >> $GITHUB_ENV
5353

54-
- name: Downgrade XCode for MacOS
55-
if: matrix.build == 'macos'
56-
run: sudo xcodes select 14.3.1
54+
- name: Select XCode for MacOS
55+
if: runner.os == 'macOS'
56+
run: |
57+
xcodes installed
58+
sudo xcodes select 15.4
5759
5860
- name: Build
5961
if: steps.check-cache.outputs.cache-hit != 'true'

.github/workflows/ci.yml

Lines changed: 63 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ jobs:
1919
name: Build Windows
2020
uses: ./.github/workflows/build-native.yml
2121
with:
22-
runner: windows-latest
23-
binary: windows
24-
build: '["windows"]'
22+
runner: windows-latest
23+
binary: windows
24+
build: '["windows"]'
2525

2626
build-macos:
2727
name: Build MacOS
@@ -35,23 +35,23 @@ jobs:
3535
name: Build Linux
3636
uses: ./.github/workflows/build-native.yml
3737
with:
38-
runner: ubuntu-20.04 # Building on the lowest possible Linux (Ubuntu) version for compatibility
39-
binary: linux
40-
build: '["linux"]'
38+
runner: ubuntu-20.04 # Building on the lowest possible Linux (Ubuntu) version for compatibility
39+
binary: linux
40+
build: '["linux"]'
4141

4242
build-android:
4343
name: Build Android
4444
uses: ./.github/workflows/build-native.yml
4545
with:
46-
runner: ubuntu-20.04
47-
binary: android
48-
build: '["android-x86_64", "android-armeabi-v7a", "android-arm64-v8a"]'
46+
runner: ubuntu-20.04
47+
binary: android
48+
build: '["android-x86_64", "android-armeabi-v7a", "android-arm64-v8a"]'
4949

5050
build-ios:
5151
name: Build IOS
5252
uses: ./.github/workflows/build-native.yml
5353
with:
54-
runner: macos-12
54+
runner: macos-14
5555
binary: ios
5656
build: '["ios-device", "ios-simulator"]'
5757

@@ -65,7 +65,7 @@ jobs:
6565
needs: build-ios
6666
uses: ./.github/workflows/binary-combine-ios.yml
6767

68-
# Dart jobs
68+
# Dart jobs
6969

7070
deploy-cluster-dart-windows:
7171
name: Deploy Cluster for Dart Windows
@@ -82,7 +82,6 @@ jobs:
8282
- deploy-cluster-dart-windows
8383
secrets: inherit
8484
with:
85-
os: windows
8685
runner: windows-latest
8786
differentiator: dw${{ github.run_id }}${{ github.run_attempt }}
8887

@@ -111,8 +110,7 @@ jobs:
111110
- deploy-cluster-dart-macos
112111
secrets: inherit
113112
with:
114-
os: macos
115-
runner: macos-latest
113+
runner: macos-13
116114
differentiator: dm${{ github.run_id }}${{ github.run_attempt }}
117115

118116
cleanup-cluster-dart-macos:
@@ -140,9 +138,8 @@ jobs:
140138
- deploy-cluster-dart-macos-arm
141139
secrets: inherit
142140
with:
143-
os: macos
144141
runner: macos-14
145-
architecture: arm
142+
arch: arm64
146143
differentiator: dma${{ github.run_id }}${{ github.run_attempt }}
147144

148145
cleanup-cluster-dart-macos-arm:
@@ -170,7 +167,6 @@ jobs:
170167
- deploy-cluster-dart-linux
171168
secrets: inherit
172169
with:
173-
os: linux
174170
runner: ubuntu-latest
175171
differentiator: dl${{ github.run_id }}${{ github.run_attempt }}
176172

@@ -184,7 +180,7 @@ jobs:
184180
with:
185181
differentiator: dl${{ github.run_id }}${{ github.run_attempt }}
186182

187-
# Flutter jobs
183+
# Flutter jobs
188184
deploy-cluster-flutter-windows:
189185
name: Deploy Cluster for Flutter Windows
190186
uses: ./.github/workflows/deploy-baas.yml
@@ -200,11 +196,9 @@ jobs:
200196
- deploy-cluster-flutter-windows
201197
secrets: inherit
202198
with:
203-
os: windows
204199
runner: windows-latest
205200
differentiator: fw${{ github.run_id }}${{ github.run_attempt }}
206201

207-
208202
cleanup-cluster-flutter-windows:
209203
name: Cleanup Cluster for Flutter Windows
210204
uses: ./.github/workflows/terminate-baas.yml
@@ -230,8 +224,7 @@ jobs:
230224
- deploy-cluster-flutter-macos
231225
secrets: inherit
232226
with:
233-
os: macos
234-
runner: macos-latest
227+
runner: macos-13
235228
differentiator: fm${{ github.run_id }}${{ github.run_attempt }}
236229

237230
cleanup-cluster-flutter-macos:
@@ -244,6 +237,35 @@ jobs:
244237
with:
245238
differentiator: fm${{ github.run_id }}${{ github.run_attempt }}
246239

240+
deploy-cluster-flutter-macos-arm:
241+
name: Deploy Cluster for Flutter MacOS Arm
242+
uses: ./.github/workflows/deploy-baas.yml
243+
secrets: inherit
244+
with:
245+
differentiator: fma${{ github.run_id }}${{ github.run_attempt }}
246+
247+
flutter-tests-macos-arm:
248+
name: Flutter Tests MacOS Arm
249+
uses: ./.github/workflows/flutter-desktop-tests.yml
250+
needs:
251+
- build-macos
252+
- deploy-cluster-flutter-macos-arm
253+
secrets: inherit
254+
with:
255+
runner: macos-14
256+
arch: arm64
257+
differentiator: fma${{ github.run_id }}${{ github.run_attempt }}
258+
259+
cleanup-cluster-flutter-macos-arm:
260+
name: Cleanup Cluster for Flutter macOS Arm
261+
uses: ./.github/workflows/terminate-baas.yml
262+
if: always()
263+
needs:
264+
- flutter-tests-macos-arm
265+
secrets: inherit
266+
with:
267+
differentiator: fma${{ github.run_id }}${{ github.run_attempt }}
268+
247269
deploy-cluster-flutter-linux:
248270
name: Deploy Cluster for Flutter Linux
249271
uses: ./.github/workflows/deploy-baas.yml
@@ -259,7 +281,6 @@ jobs:
259281
- deploy-cluster-flutter-linux
260282
secrets: inherit
261283
with:
262-
os: linux
263284
runner: ubuntu-latest
264285
differentiator: fl${{ github.run_id }}${{ github.run_attempt }}
265286

@@ -298,7 +319,12 @@ jobs:
298319
- name: Checkout
299320
uses: actions/checkout@v4
300321
with:
301-
submodules: 'recursive'
322+
submodules: "recursive"
323+
324+
- name: Bump ulimit
325+
run: |
326+
ulimit -n
327+
ulimit -n 10240
302328
303329
- name: Enable ccache
304330
run: echo "PATH=/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH" >> $GITHUB_ENV
@@ -312,7 +338,7 @@ jobs:
312338
- name: Setup Flutter
313339
uses: subosito/flutter-action@v2
314340
with:
315-
channel: 'stable'
341+
channel: "stable"
316342

317343
- name: Setup Melos
318344
run: |
@@ -325,9 +351,9 @@ jobs:
325351
- name: Launch Simulator
326352
uses: futureware-tech/simulator-action@v3
327353
with:
328-
model: 'iPhone SE (3rd generation)'
329-
os: 'iOS'
330-
os_version: '>= 14.0'
354+
model: "iPhone SE (3rd generation)"
355+
os: "iOS"
356+
os_version: ">= 14.0"
331357

332358
- name: Run tests on iOS Simulator
333359
run: |
@@ -382,7 +408,7 @@ jobs:
382408
- name: Checkout
383409
uses: actions/checkout@v4
384410
with:
385-
submodules: 'recursive'
411+
submodules: "recursive"
386412

387413
- name: Enable KVM
388414
run: |
@@ -396,7 +422,7 @@ jobs:
396422
- name: Setup Java
397423
uses: actions/setup-java@v4
398424
with:
399-
distribution: 'temurin'
425+
distribution: "temurin"
400426
java-version: 11
401427

402428
- name: Fetch artifacts
@@ -408,7 +434,7 @@ jobs:
408434
- name: Setup Flutter
409435
uses: subosito/flutter-action@v2
410436
with:
411-
channel: 'stable'
437+
channel: "stable"
412438

413439
- name: Setup Melos
414440
run: |
@@ -419,7 +445,7 @@ jobs:
419445
run: dart pub get
420446

421447
# Hack to free up space on the runner to ensure we have enough diskspace to run the emulator
422-
- name: Remove unnecessary files (dotnet, etc.)
448+
- name: Remove unnecessary files (dotnet, etc.)
423449
run: |
424450
sudo rm -rf /usr/share/dotnet
425451
@@ -468,7 +494,6 @@ jobs:
468494
only-summary: true
469495
working-directory: packages/realm/tests
470496

471-
472497
cleanup-cluster-flutter-android:
473498
name: Cleanup Cluster for Flutter Android
474499
uses: ./.github/workflows/terminate-baas.yml
@@ -479,7 +504,7 @@ jobs:
479504
with:
480505
differentiator: fa${{ github.run_id }}${{ github.run_attempt }}
481506

482-
# Generator jobs
507+
# Generator jobs
483508

484509
generator:
485510
strategy:
@@ -499,12 +524,12 @@ jobs:
499524
- name: Checkout
500525
uses: actions/checkout@v4
501526
with:
502-
submodules: 'recursive'
527+
submodules: "recursive"
503528

504529
- name: Setup Flutter
505530
uses: subosito/flutter-action@v2
506531
with:
507-
channel: 'stable'
532+
channel: "stable"
508533

509534
- name: Setup Melos
510535
run: |
@@ -580,7 +605,7 @@ jobs:
580605
runs-on: ubuntu-latest
581606
if: always() && github.ref == 'refs/heads/main'
582607
steps:
583-
# Run this action to set env.WORKFLOW_CONCLUSION
608+
# Run this action to set env.WORKFLOW_CONCLUSION
584609
- uses: technote-space/workflow-conclusion-action@45ce8e0eb155657ab8ccf346ade734257fd196a5
585610

586611
- uses: act10ns/slack@ed1309ab9862e57e9e583e51c7889486b9a00b0f
@@ -589,7 +614,7 @@ jobs:
589614
with:
590615
status: ${{ env.WORKFLOW_CONCLUSION }}
591616
webhook-url: ${{ secrets.SLACK_DART_WEBHOOK }}
592-
channel: '#realm-github-dart'
617+
channel: "#realm-github-dart"
593618
message: |
594619
*<https://github.com/realm/realm-dart/actions/runs/${{ github.run_id }}/attempts/${{ github.run_attempt }}|_{{workflow}}_ run id: ${{ github.run_id }} has status _{{jobStatus}}_ >*
595620
<{{refUrl}}|`{{ref}}` - {{description}}>

0 commit comments

Comments
 (0)