Work with the ID of a person

Author: acsany

build-a-rest-api-frontend/source_code_working/models.py

@@ -26,7 +26,7 @@ class Meta:
 class Person(db.Model):
     __tablename__ = "person"
     id = db.Column(db.Integer, primary_key=True)
-    lname = db.Column(db.String(32))
+    lname = db.Column(db.String(32), nullable=False)
     fname = db.Column(db.String(32))
     timestamp = db.Column(
         db.DateTime, default=datetime.utcnow, onupdate=datetime.utcnow

build-a-rest-api-frontend/source_code_working/people.py

@@ -10,46 +10,41 @@ def read_all():
 
 
 def create(person):
-    lname = person.get("lname")
-    existing_person = Person.query.filter(Person.lname == lname).one_or_none()
-
-    if existing_person is None:
-        new_person = person_schema.load(person, session=db.session)
-        db.session.add(new_person)
-        db.session.commit()
-        return person_schema.dump(new_person), 201
-    else:
-        abort(406, f"Person with last name {lname} already exists")
+    new_person = person_schema.load(person, session=db.session)
+    db.session.add(new_person)
+    db.session.commit()
+    return person_schema.dump(new_person), 201
 
 
-def read_one(lname):
-    person = Person.query.filter(Person.lname == lname).one_or_none()
+def read_one(person_id):
+    person = Person.query.get(person_id)
 
     if person is not None:
         return person_schema.dump(person)
     else:
-        abort(404, f"Person with last name {lname} not found")
+        abort(404, f"Person with ID {person_id} not found")
 
 
-def update(lname, person):
-    existing_person = Person.query.filter(Person.lname == lname).one_or_none()
+def update(person_id, person):
+    existing_person = Person.query.get(person_id)
 
     if existing_person:
         update_person = person_schema.load(person, session=db.session)
         existing_person.fname = update_person.fname
+        existing_person.lname = update_person.lname
         db.session.merge(existing_person)
         db.session.commit()
         return person_schema.dump(existing_person), 201
     else:
-        abort(404, f"Person with last name {lname} not found")
+        abort(404, f"Person with ID {person_id} not found")
 
 
-def delete(lname):
-    existing_person = Person.query.filter(Person.lname == lname).one_or_none()
+def delete(person_id):
+    existing_person = Person.query.get(person_id)
 
     if existing_person:
         db.session.delete(existing_person)
         db.session.commit()
-        return make_response(f"{lname} successfully deleted", 200)
+        return make_response(f"{person_id} successfully deleted", 200)
     else:
-        abort(404, f"Person with last name {lname} not found")
+        abort(404, f"Person with ID {person_id} not found")

build-a-rest-api-frontend/source_code_working/swagger.yml

@@ -19,9 +19,9 @@ components:
         lname:
           type: "string"
   parameters:
-    lname:
-      name: "lname"
-      description: "Last name of the person to get"
+    person_id:
+      name: "person_id"
+      description: "ID of the person to get"
       in: path
       required: True
       schema:
@@ -50,24 +50,24 @@ paths:
         - People
       summary: "Create a person"
       requestBody:
-          description: "Person to create"
-          required: True
-          content:
-            application/json:
-              schema:
-                x-body-name: "person"
-                $ref: "#/components/schemas/Person"
+        description: "Person to create"
+        required: True
+        content:
+          application/json:
+            schema:
+              x-body-name: "person"
+              $ref: "#/components/schemas/Person"
       responses:
         "201":
           description: "Successfully created person"
-  /people/{lname}:
+  /people/{person_id}:
     get:
       operationId: "people.read_one"
       tags:
         - People
       summary: "Read one person"
       parameters:
-        - $ref: "#/components/parameters/lname"
+        - $ref: "#/components/parameters/person_id"
       responses:
         "200":
           description: "Successfully read person"
@@ -77,7 +77,7 @@ paths:
       operationId: "people.update"
       summary: "Update a person"
       parameters:
-        - $ref: "#/components/parameters/lname"
+        - $ref: "#/components/parameters/person_id"
       responses:
         "200":
           description: "Successfully updated person"
@@ -93,7 +93,7 @@ paths:
       operationId: "people.delete"
       summary: "Delete a person"
       parameters:
-        - $ref: "#/components/parameters/lname"
+        - $ref: "#/components/parameters/person_id"
       responses:
         "204":
           description: "Successfully deleted person"
@@ -104,18 +104,18 @@ paths:
         - Notes
       summary: "Create a note associated with a person"
       requestBody:
-          description: "Note to create"
-          required: True
-          content:
-            application/json:
-              schema:
-                x-body-name: "note"
-                type: "object"
-                properties:
-                  person_id:
-                    type: "integer"
-                  content:
-                    type: "string"
+        description: "Note to create"
+        required: True
+        content:
+          application/json:
+            schema:
+              x-body-name: "note"
+              type: "object"
+              properties:
+                person_id:
+                  type: "integer"
+                content:
+                  type: "string"
       responses:
         "201":
           description: "Successfully created a note"