Suggested refactoring of performance script

Author: gahjelle

python-flatten-list/flatten.py

@@ -0,0 +1,45 @@
+from functools import reduce
+from itertools import chain
+from operator import add, concat, iconcat
+
+
+def flatten_comprehension(matrix):
+    return [item for row in matrix for item in row]
+
+
+def flatten_concatenation(matrix):
+    flat = []
+    for row in matrix:
+        flat += row
+    return flat
+
+
+def flatten_extend(matrix):
+    flat = []
+    for row in matrix:
+        flat.extend(row)
+    return flat
+
+
+def flatten_itertools_chain(matrix):
+    return list(chain.from_iterable(matrix))
+
+
+def flatten_reduce_add(matrix):
+    return reduce(add, matrix, [])
+
+
+def flatten_reduce_concat(matrix):
+    return reduce(concat, matrix, [])
+
+
+def flatten_reduce_iconcat(matrix):
+    return reduce(iconcat, matrix, [])
+
+
+def flatten_reduce_lambda(matrix):
+    return list(reduce(lambda x, y: x + y, matrix, []))
+
+
+def flatten_sum(matrix):
+    return sum(matrix, [])

python-flatten-list/performance.py

@@ -1,40 +1,30 @@
 from timeit import timeit
 
-from flatten_comprehension import flatten_comprehension
-from flatten_concatenation import flatten_concatenation
-from flatten_extend import flatten_extend
-from flatten_itertool_chain import flatten_itertools_chain
-from flatten_reduce_add import flatten_reduce_add
-from flatten_reduce_concat import flatten_reduce_concat
-from flatten_reduce_iconcat import flatten_reduce_iconcat
-from flatten_reduce_lambda import flatten_reduce_lambda
-from flatten_sum import flatten_sum
+import flatten  # noqa
 
 SIZE = 1000
 TO_MS = 1000
+NUM = 10
 FUNCTIONS = [
-    flatten_comprehension,
-    flatten_concatenation,
-    flatten_extend,
-    flatten_reduce_lambda,
-    flatten_sum,
-    flatten_itertools_chain,
-    flatten_reduce_add,
-    flatten_reduce_concat,
-    flatten_reduce_iconcat,
+    "flatten_comprehension",
+    "flatten_concatenation",
+    "flatten_extend",
+    "flatten_reduce_lambda",
+    "flatten_sum",
+    "flatten_itertools_chain",
+    "flatten_reduce_add",
+    "flatten_reduce_concat",
+    "flatten_reduce_iconcat",
 ]
 
 matrix = [list(range(SIZE))] * SIZE
 
-results = [
-    (
-        f"{func.__name__}()",
-        timeit(f"{func(matrix)}", globals=globals(), number=1) * TO_MS,
-    )
+results = {
+    func: timeit(f"flatten.{func}(matrix)", globals=globals(), number=NUM)
     for func in FUNCTIONS
-]
+}
 
 print(f"Time to flatten a {SIZE}x{SIZE} matrix (in milliseconds):\n")
 
-for func, time in sorted(results, key=lambda result: result[1]):
-    print(f"{func:.<30}{time: >7.6f} ms")
+for func, time in sorted(results.items(), key=lambda result: result[1]):
+    print(f"{func + '()':.<30}{time * TO_MS / NUM:.>10.6f} ms")