Merge pull request #256 from realpython/python-connectivity-checker-FQA

Update code as per FQA

Author: lpozo

python-site-connectivity-checker/source_code_final/rpchecker/__main__.py

@@ -12,7 +12,7 @@ def main():
     """Run RP Checker."""
     user_args = read_user_cli_args()
     urls = _get_websites_urls(user_args)
-    if len(urls) == 0:
+    if not urls:
         print("Error: no URLs to check", file=sys.stderr)
         sys.exit(1)
 
@@ -34,7 +34,7 @@ def _read_urls_from_file(file):
     if file_path.is_file():
         with file_path.open() as urls_file:
             urls = [url.strip() for url in urls_file]
-            if len(urls) > 0:
+            if urls:
                 return urls
             print(f"Error: empty input file, {file}", file=sys.stderr)
     else:

python-site-connectivity-checker/source_code_final/rpchecker/checker.py

@@ -6,7 +6,7 @@
 
 
 def site_is_online(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """
@@ -26,7 +26,7 @@ def site_is_online(url, timeout=2):
 
 
 async def site_is_online_async(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """

python-site-connectivity-checker/source_code_step_2/rpchecker/checker.py

@@ -3,7 +3,7 @@
 
 
 def site_is_online(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """

python-site-connectivity-checker/source_code_step_3/rpchecker/checker.py

@@ -3,7 +3,7 @@
 
 
 def site_is_online(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """

python-site-connectivity-checker/source_code_step_4/rpchecker/__main__.py

@@ -9,7 +9,7 @@ def main():
     """Run RP Checker."""
     user_args = read_user_cli_args()
     urls = _get_websites_urls(user_args)
-    if len(urls) == 0:
+    if not urls:
         print("Error: no URLs to check", file=sys.stderr)
         sys.exit(1)
     _synchronous_check(urls)
@@ -27,7 +27,7 @@ def _read_urls_from_file(file):
     if file_path.is_file():
         with file_path.open() as urls_file:
             urls = [url.strip() for url in urls_file]
-            if len(urls) > 0:
+            if urls:
                 return urls
             print(f"Error: empty input file, {file}", file=sys.stderr)
     else:

python-site-connectivity-checker/source_code_step_4/rpchecker/checker.py

@@ -3,7 +3,7 @@
 
 
 def site_is_online(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """

python-site-connectivity-checker/source_code_step_5/rpchecker/__main__.py

@@ -12,7 +12,7 @@ def main():
     """Run RP Checker."""
     user_args = read_user_cli_args()
     urls = _get_websites_urls(user_args)
-    if len(urls) == 0:
+    if not urls:
         print("Error: no URLs to check", file=sys.stderr)
         sys.exit(1)
 
@@ -34,7 +34,7 @@ def _read_urls_from_file(file):
     if file_path.is_file():
         with file_path.open() as urls_file:
             urls = [url.strip() for url in urls_file]
-            if len(urls) > 0:
+            if urls:
                 return urls
             print(f"Error: empty input file, {file}", file=sys.stderr)
     else:

python-site-connectivity-checker/source_code_step_5/rpchecker/checker.py

@@ -6,7 +6,7 @@
 
 
 def site_is_online(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """
@@ -26,7 +26,7 @@ def site_is_online(url, timeout=2):
 
 
 async def site_is_online_async(url, timeout=2):
-    """Return a True if the target URL is online.
+    """Return True if the target URL is online.
 
     Raise an exception otherwise.
     """