TR updates, first round

Author: lpozo

python-unittest/calculations.py

@@ -15,7 +15,7 @@ def multiply(x, y):
 
 def divide(x, y):
     if y == 0:
-        raise ValueError("Cannot divide by zero.")
+        raise ZeroDivisionError("Cannot divide by zero.")
     return x / y
 
 

python-unittest/employee.py

@@ -11,8 +11,8 @@ def __init__(self, name, age, job, salary):
         self.salary = salary
 
     def profile(self):
-        for key, value in self.__dict__.items():
-            print(f"{key.capitalize()}: {value}")
+        for attr in self.__slots__:
+            print(f"{attr.capitalize()}: {getattr(self, attr)}")
         print()
 
 
@@ -24,9 +24,9 @@ def from_csv_file(file_path):
             employees.append(
                 Employee(
                     name=row["name"],
-                    age=row["age"],
+                    age=int(row["age"]),
                     job=row["job"],
-                    salary=row["salary"],
+                    salary=float(row["salary"]),
                 )
             )
         return employees

python-unittest/fake_date.py

@@ -15,4 +15,4 @@ def __iter__(self):
         return iter(self.items)
 
     def __reversed__(self):
-        return type(self)(reversed(self.items))
+        return reversed(self.items)

python-unittest/stack.py

@@ -19,7 +19,7 @@ def test_multiply(self):
     def test_divide(self):
         self.assertEqual(divide(10, 5), 2)
         self.assertEqual(divide(-1, 1), -1)
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ZeroDivisionError):
             divide(10, 0)
 
 
@@ -83,7 +83,7 @@ def test_mode_multiple(self):
 #     runner.run(suite)
 
 
-def load_tests(loader, tests, pattern):
+def load_tests(loader, standard_tests, pattern):
     suite = unittest.TestSuite()
     suite.addTests(loader.loadTestsFromTestCase(TestArithmeticOperations))
     suite.addTests(loader.loadTestsFromTestCase(TestStatisticalOperations))

python-unittest/test_calculations.py

@@ -23,8 +23,8 @@ def test_dictionary_objects(self):
         self.assertDictEqual(a, b)
 
     def test_set_objects(self):
-        a = {1, 2, 3, 4, 5}
-        b = {1, 2, 3, 4, 5}
+        a = {1, 2, 4, 3, 5}
+        b = {1, 5, 3, 4, 2}
         self.assertSetEqual(a, b)
 
 

python-unittest/test_collections.py

@@ -3,11 +3,10 @@
 
 class CustomTestCase(unittest.TestCase):
     def assertAllIntegers(self, values):
-        for index, value in enumerate(values):
+        for value in values:
             self.assertIsInstance(
                 value,
                 int,
-                f"Value at index {index} is not an integer: {value}",
             )
 
 

python-unittest/test_custom.py

@@ -35,9 +35,9 @@ def test_from_csv_file_total_employees(self):
 
     def test_from_csv_file_employee_attributes(self):
         self.assertEqual(self.employees[0].name, "Alice")
-        self.assertEqual(self.employees[0].age, "25")
+        self.assertEqual(self.employees[0].age, 25)
         self.assertEqual(self.employees[0].job, "Engineer")
-        self.assertEqual(self.employees[0].salary, "50000")
+        self.assertEqual(self.employees[0].salary, 50000.0)
 
     def test_from_csv_file_employee_name(self):
         self.assertEqual(self.employees[0].name, "Alice")

python-unittest/test_employee.py

@@ -36,7 +36,7 @@ def test_reversed(self):
         for item in items:
             self.stack.push(item)
         reversed_stack = reversed(self.stack)
-        self.assertEqual(reversed_stack.items, [7, 6, 5])
+        self.assertEqual(list(reversed_stack), [7, 6, 5])
 
 
 if __name__ == "__main__":

python-unittest/test_stack.py

@@ -0,0 +1,21 @@
+import datetime
+import unittest
+from unittest.mock import patch
+
+import weekday
+
+
+class TestWeekday(unittest.TestCase):
+    @patch("weekday.datetime")
+    def test_is_weekday(self, mock_datetime):
+        mock_datetime.date.today.return_value = datetime.date(2024, 4, 4)
+        self.assertTrue(weekday.is_weekday())
+
+    @patch("weekday.datetime")
+    def test_is_weekend(self, mock_datetime):
+        mock_datetime.date.today.return_value = datetime.date(2024, 4, 6)
+        self.assertFalse(weekday.is_weekday())
+
+
+if __name__ == "__main__":
+    unittest.main(verbosity=2)