Final QA updates

Author: gahjelle

top-python-game-engines/README.md

@@ -85,9 +85,11 @@ Alternately, you can use `pgzrun` to run both games:
 ```
 
 ### Note
-Checkers like [flake8 are unaware](https://pygame-zero.readthedocs.io/en/latest/installation.html#for-flake8-pyflakes) of Pygame Zero's extra built-ins.
-That's why xou'll find `# noqa: F821` inline comments in `pygame_zero_basic.py` and `pygame_zero_game.py`.
-With the `# noqa` inline comments [flake8](https://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors) ignores the errors that these lines would cause.
+
+Linters like [flake8 are unaware](https://pygame-zero.readthedocs.io/en/latest/installation.html#for-flake8-pyflakes) of Pygame Zero's extra built-ins.
+That's why you'll find `# noqa: F821` inline comments in `pygame_zero_basic.py` and `pygame_zero_game.py`.
+
+With the `# noqa` inline comments [flake8](https://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors) ignores the linter errors that these lines would cause.
 
 ## Arcade
 

top-python-game-engines/adventurelib/adventurelib_basic.py

@@ -117,10 +117,9 @@ def go(direction: str):
 @adv.when("look")
 def look():
     """Looks at the current room"""
-    global current_room
 
     # Describe the room
-    adv.say(f"{current_room}")
+    adv.say(current_room)
 
     # List the contents
     for item in current_room.contents:
@@ -173,8 +172,6 @@ def use(item: str):
         item {str} -- Which item to use
     """
 
-    global inventory
-
     # First, do you have the item?
     obj = inventory.take(item)
     if not obj:

top-python-game-engines/adventurelib/adventurelib_game.py

@@ -71,7 +71,7 @@ def look_at(item: str):
         if not obj:
             print(f"I can't find {item} anywhere.")
         else:
-            print(f"You current have {item}.")
+            print(f"You have {item}.")
     else:
         print(f"You see {item}.")
 
@@ -96,7 +96,7 @@ def describe(item: str):
         if not obj:
             print(f"I can't find {item} anywhere.")
         else:
-            print(f"You current have {obj.description}.")
+            print(f"You have {obj.description}.")
     else:
         print(f"You see {obj.description}.")
 
@@ -134,7 +134,7 @@ def eat(item: str):
         inventory.take(item)
 
     else:
-        print(f"How do propose we eat {obj.description}?")
+        print(f"How do you propose we eat {obj.description}?")
 
 
 @adv.when("wear ITEM")
@@ -200,7 +200,7 @@ def yes_elder():
     offering, and use it well!
     """
     )
-    current_room.items.add(adventurelib_game_items.wooden_sword)
+    inventory.add(adventurelib_game_items.wooden_sword)
     current_room.locked_exits["south"] = False
 
 
@@ -290,7 +290,7 @@ def fight_giant(character: str):
 
     # Is the giant dead?
     if giant_hit_points <= 0:
-        end_game(True)
+        end_game(victory=True)
 
     print_giant_condition()
     print()
@@ -310,7 +310,7 @@ def fight_giant(character: str):
 
     # Is the player dead?
     if hit_points <= 0:
-        end_game(False)
+        end_game(victory=False)
 
     print_player_condition()
     print()
@@ -485,8 +485,8 @@ def go(direction: str):
             # Clear the context if necessary
             current_context = adv.get_context()
             if current_context == "giant":
-                print(
-                    """You way is currently blocked.\
+                adv.say(
+                    """Your way is currently blocked.
                     Or have you forgotten the giant you are fighting?"""
                 )
             else:
@@ -504,7 +504,7 @@ def go(direction: str):
 
 
 # Define a prompt
-def my_prompt():
+def prompt():
     global current_room
 
     # Get possible exits
@@ -516,10 +516,10 @@ def my_prompt():
     else:
         prompt_string = f"({current_room.title}) > "
 
-    return f"""({exits_string}) {prompt_string} """
+    return f"""({exits_string}) {prompt_string}"""
 
 
-def my_no_command_matches(command: str):
+def no_command_matches(command: str):
     if adv.get_context() == "wizard.riddle":
         adv.say("That is not the correct answer. Begone!")
         adv.set_context(None)
@@ -544,10 +544,10 @@ def get_exits(room):
     adv.set_context(None)
 
     # Set the prompt
-    adv.prompt = my_prompt
+    adv.prompt = prompt
 
     # What happens with unknown commands
-    adv.no_command_matches = my_no_command_matches
+    adv.no_command_matches = no_command_matches
 
     # Look at your starting room
     look()

top-python-game-engines/adventurelib/adventurelib_game_rooms.py

@@ -123,7 +123,7 @@ def __init__(self, description: str):
 side_path = GameArea(
     """
 The path leads away from the fork to Dunhaven. Fresh tracks of
-something big, dragging something behind it, lead away to the east.
+something big, dragging something behind it, lead away to the south.
 """
 )
 side_path.title = "Side path"

top-python-game-engines/pygame_zero/pygame_zero_game.py

@@ -45,7 +45,7 @@ def add_coin():
     """Adds a new coin to playfield, then
     schedules the next coin to be added
     """
-    global coin_list, coin_countdown
+    global coin_countdown
 
     # Create a new coin Actor at a random location
     new_coin = Actor(  # noqa: F821
@@ -97,7 +97,7 @@ def update(delta_time: float):
     Arguments:
         delta_time {float} -- Time since the last frame
     """
-    global coin_list, score
+    global score
 
     # Update the player position
     player.center = player_position