Merge pull request #242 from realpython/weather-app-final-qa

gahjelle · web-flow · commit 569fd1370651 · 2022-02-18T08:57:04.000+01:00
Weather App: Final QA updates
diff --git a/weather-app/source_code_final/style.py b/weather-app/source_code_final/style.py
@@ -1,6 +1,3 @@
-import sys
-
-
 PADDING = 20
 
 RED = "\033[1;31m"
@@ -15,4 +12,4 @@
 
 
 def change_color(color):
-    sys.stdout.write(color)
+    print(color, end="")
diff --git a/weather-app/source_code_final/weather.py b/weather-app/source_code_final/weather.py
@@ -29,7 +29,7 @@ def read_user_cli_args():
         description="gets weather and temperature information for a city"
     )
     parser.add_argument(
-        "City", metavar="city", nargs="+", type=str, help="enter the city name"
+        "city", nargs="+", type=str, help="enter the city name"
     )
     parser.add_argument(
         "-i",
@@ -162,6 +162,6 @@ def _select_weather_display_params(weather_id):
 
 if __name__ == "__main__":
     user_args = read_user_cli_args()
-    query_url = build_weather_query(user_args.City, user_args.imperial)
+    query_url = build_weather_query(user_args.city, user_args.imperial)
     weather_data = get_weather_data(query_url)
     display_weather_info(weather_data, user_args.imperial)
diff --git a/weather-app/source_code_step_3/weather.py b/weather-app/source_code_step_3/weather.py
@@ -12,7 +12,7 @@ def read_user_cli_args():
         description="gets weather and temperature information for a city"
     )
     parser.add_argument(
-        "City", metavar="city", nargs="+", type=str, help="enter the city name"
+        "city", nargs="+", type=str, help="enter the city name"
     )
     parser.add_argument(
         "-i",
@@ -38,4 +38,4 @@ def _get_api_key():
 
 if __name__ == "__main__":
     user_args = read_user_cli_args()
-    print(user_args.City, user_args.imperial)
+    print(user_args.city, user_args.imperial)
diff --git a/weather-app/source_code_step_4/weather.py b/weather-app/source_code_step_4/weather.py
@@ -17,7 +17,7 @@ def read_user_cli_args():
         description="gets weather and temperature information for a city"
     )
     parser.add_argument(
-        "City", metavar="city", nargs="+", type=str, help="enter the city name"
+        "city", nargs="+", type=str, help="enter the city name"
     )
     parser.add_argument(
         "-i",
@@ -91,6 +91,6 @@ def get_weather_data(query_url):
 
 if __name__ == "__main__":
     user_args = read_user_cli_args()
-    query_url = build_weather_query(user_args.City, user_args.imperial)
+    query_url = build_weather_query(user_args.city, user_args.imperial)
     weather_data = get_weather_data(query_url)
     print(weather_data)
diff --git a/weather-app/source_code_step_5/weather.py b/weather-app/source_code_step_5/weather.py
@@ -18,7 +18,7 @@ def read_user_cli_args():
         description="gets weather and temperature information for a city"
     )
     parser.add_argument(
-        "City", metavar="city", nargs="+", type=str, help="enter the city name"
+        "city", nargs="+", type=str, help="enter the city name"
     )
     parser.add_argument(
         "-i",
@@ -113,6 +113,6 @@ def display_weather_info(weather_data, imperial=False):
 
 if __name__ == "__main__":
     user_args = read_user_cli_args()
-    query_url = build_weather_query(user_args.City, user_args.imperial)
+    query_url = build_weather_query(user_args.city, user_args.imperial)
     weather_data = get_weather_data(query_url)
     display_weather_info(weather_data, user_args.imperial)
diff --git a/weather-app/source_code_step_6/style.py b/weather-app/source_code_step_6/style.py
@@ -1,6 +1,3 @@
-import sys
-
-
 PADDING = 20
 
 RED = "\033[1;31m"
@@ -15,4 +12,4 @@
 
 
 def change_color(color):
-    sys.stdout.write(color)
+    print(color, end="")
diff --git a/weather-app/source_code_step_6/weather.py b/weather-app/source_code_step_6/weather.py
@@ -29,7 +29,7 @@ def read_user_cli_args():
         description="gets weather and temperature information for a city"
     )
     parser.add_argument(
-        "City", metavar="city", nargs="+", type=str, help="enter the city name"
+        "city", nargs="+", type=str, help="enter the city name"
     )
     parser.add_argument(
         "-i",
@@ -162,6 +162,6 @@ def _select_weather_display_params(weather_id):
 
 if __name__ == "__main__":
     user_args = read_user_cli_args()
-    query_url = build_weather_query(user_args.City, user_args.imperial)
+    query_url = build_weather_query(user_args.city, user_args.imperial)
     weather_data = get_weather_data(query_url)
     display_weather_info(weather_data, user_args.imperial)

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ def read_user_cli_args():`
`12`	`12`	`description="gets weather and temperature information for a city"`
`13`	`13`	`)`
`14`	`14`	`parser.add_argument(`
`15`		`- "City", metavar="city", nargs="+", type=str, help="enter the city name"`
	`15`	`+ "city", nargs="+", type=str, help="enter the city name"`
`16`	`16`	`)`
`17`	`17`	`parser.add_argument(`
`18`	`18`	`"-i",`
`@@ -38,4 +38,4 @@ def _get_api_key():`
`38`	`38`
`39`	`39`	`if __name__ == "__main__":`
`40`	`40`	`user_args = read_user_cli_args()`
`41`		`- print(user_args.City, user_args.imperial)`
	`41`	`+ print(user_args.city, user_args.imperial)`