Skip to content

Commit 59320aa

Browse files
committed
Add more TR feedback
1 parent 31012e5 commit 59320aa

File tree

6 files changed

+43
-26
lines changed

6 files changed

+43
-26
lines changed

code-image-generator/source_code_final/app.py

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from pygments.lexers import Python3Lexer
77
from pygments.styles import get_all_styles
88

9-
from utils import take_screenshot
9+
from utils import take_screenshot_from_url
1010

1111
app = Flask(__name__)
1212
app.secret_key = "mysecretkey"
@@ -36,50 +36,49 @@ def save_code():
3636
return redirect(url_for("code"))
3737

3838

39-
@app.route("/reset_session", methods=["GET"])
39+
@app.route("/reset_session", methods=["POST"])
4040
def reset_session():
4141
session.clear()
4242
session["code"] = PLACEHOLDER_CODE
4343
return redirect(url_for("code"))
4444

4545

46-
@app.route("/save_style", methods=["POST"])
47-
def save_style():
48-
if request.form.get("style") is not None:
49-
session["style"] = request.form.get("style")
50-
if request.form.get("code") is not None:
51-
session["code"] = request.form.get("code") or NO_CODE_FALLBACK
52-
return redirect(url_for("style"))
53-
54-
5546
@app.route("/style", methods=["GET"])
5647
def style():
5748
if session.get("style") is None:
5849
session["style"] = DEFAULT_STYLE
5950
formatter = HtmlFormatter(style=session["style"])
6051
context = {
6152
"message": "Select Your Style 🎨",
62-
"code": session["code"],
6353
"all_styles": list(get_all_styles()),
6454
"style": session["style"],
65-
"style_bg_color": formatter.style.background_color,
6655
"style_definitions": formatter.get_style_defs(),
56+
"style_bg_color": formatter.style.background_color,
6757
"highlighted_code": highlight(
6858
session["code"], Python3Lexer(), formatter
6959
),
7060
}
7161
return render_template("style_selection.html", **context)
7262

7363

64+
@app.route("/save_style", methods=["POST"])
65+
def save_style():
66+
if request.form.get("style") is not None:
67+
session["style"] = request.form.get("style")
68+
if request.form.get("code") is not None:
69+
session["code"] = request.form.get("code") or NO_CODE_FALLBACK
70+
return redirect(url_for("style"))
71+
72+
7473
@app.route("/image", methods=["GET"])
7574
def image():
76-
session_dict = {
75+
session_data = {
7776
"name": app.config["SESSION_COOKIE_NAME"],
7877
"value": request.cookies.get(app.config["SESSION_COOKIE_NAME"]),
7978
"url": request.host_url,
8079
}
8180
target_url = request.host_url + url_for("style")
82-
image_bytes = take_screenshot(target_url, session_dict)
81+
image_bytes = take_screenshot_from_url(target_url, session_data)
8382
context = {
8483
"message": "Done! 🎉",
8584
"image_b64": base64.b64encode(image_bytes).decode("utf-8"),

code-image-generator/source_code_final/static/styles.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ select {
6060
line-height: 1.4em;
6161
}
6262

63-
.code_picture {
63+
.code-picture {
6464
text-align: center;
6565
}
6666

67-
img {
67+
.code-picture img {
6868
margin: 1em 0;
6969
border: 1px solid #cecece;
7070
max-width: 80%;
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
from playwright.sync_api import sync_playwright
22

33

4-
def take_screenshot(target, session_dict):
4+
def take_screenshot_from_url(url, session_data):
55
with sync_playwright() as playwright:
66
webkit = playwright.webkit
77
browser = webkit.launch()
88
browser_context = browser.new_context(device_scale_factor=2)
9-
browser_context.add_cookies([session_dict])
9+
browser_context.add_cookies([session_data])
1010
page = browser_context.new_page()
11-
page.goto(target)
11+
page.goto(url)
1212
screenshot_bytes = page.locator(".code").screenshot()
1313
browser.close()
1414
return screenshot_bytes

code-image-generator/source_code_step_02/app.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
from flask import Flask, render_template, session, request, redirect, url_for
1+
from flask import (
2+
Flask,
3+
redirect,
4+
render_template,
5+
request,
6+
session,
7+
url_for,
8+
)
29

310
app = Flask(__name__)
411
app.secret_key = "mysecretkey"

code-image-generator/source_code_step_03/app.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
from flask import Flask, render_template, session, request, redirect, url_for
1+
from flask import (
2+
Flask,
3+
redirect,
4+
render_template,
5+
request,
6+
session,
7+
url_for,
8+
)
29
from pygments import highlight
310
from pygments.formatters import HtmlFormatter
411
from pygments.lexers import Python3Lexer
@@ -45,7 +52,6 @@ def style():
4552
formatter = HtmlFormatter(style=session["style"])
4653
context = {
4754
"message": "Select Your Style 🎨",
48-
"code": session["code"],
4955
"all_styles": list(get_all_styles()),
5056
"style_definitions": formatter.get_style_defs(),
5157
"style_bg_color": formatter.style.background_color,

code-image-generator/source_code_step_04/app.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
import base64
2-
3-
from flask import Flask, render_template, session, request, redirect, url_for
2+
from flask import (
3+
Flask,
4+
redirect,
5+
render_template,
6+
request,
7+
session,
8+
url_for,
9+
)
410
from pygments import highlight
511
from pygments.formatters import HtmlFormatter
612
from pygments.lexers import Python3Lexer
@@ -49,7 +55,6 @@ def style():
4955
formatter = HtmlFormatter(style=session["style"])
5056
context = {
5157
"message": "Select Your Style 🎨",
52-
"code": session["code"],
5358
"all_styles": list(get_all_styles()),
5459
"style_definitions": formatter.get_style_defs(),
5560
"style_bg_color": formatter.style.background_color,

0 commit comments

Comments
 (0)