TR update, first round

Author: lpozo

python-inherit-list-userlist/custom_list1.py

@@ -1,6 +1,6 @@
 class CustomList(list):
-    def join(self, sep=" "):
-        return sep.join(str(item) for item in self)
+    def join(self, separator=" "):
+        return separator.join(str(item) for item in self)
 
     def map(self, action):
         return type(self)(action(item) for item in self)
@@ -10,4 +10,4 @@ def filter(self, predicate):
 
     def for_each(self, func):
         for item in self:
-            yield func(item)
+            func(item)

python-inherit-list-userlist/custom_list2.py

@@ -2,8 +2,8 @@
 
 
 class CustomList(UserList):
-    def join(self, sep=" "):
-        return sep.join(self.data)
+    def join(self, separator=" "):
+        return separator.join(str(item) for item in self)
 
     def map(self, action):
         return type(self)(action(item) for item in self.data)
@@ -13,4 +13,4 @@ def filter(self, predicate):
 
     def for_each(self, func):
         for item in self.data:
-            yield func(item)
+            func(item)

python-inherit-list-userlist/number_list2.py

@@ -3,7 +3,7 @@
 
 class NumberList(UserList):
     def __init__(self, iterable):
-        self.data = [self._validate_number(item) for item in iterable]
+        super().__init__(self._validate_number(item) for item in iterable)
 
     def __setitem__(self, index, item):
         self.data[index] = self._validate_number(item)

python-inherit-list-userlist/performance.py

@@ -24,7 +24,7 @@ def extend(self, other):
 
 class StringList_UserList(UserList):
     def __init__(self, iterable):
-        self.data = [str(item) for item in iterable]
+        super().__init__(str(item) for item in iterable)
 
     def __setitem__(self, index, item):
         self.data[index] = str(item)
@@ -44,51 +44,31 @@ def extend(self, other):
 
 init_data = range(10000)
 
-list_initialization = min(
-    timeit.repeat(
-        stmt="StringList_list(init_data)",
-        number=1000,
-        repeat=5,
-        globals=globals(),
-    )
-)
-
-user_list_initialization = min(
-    timeit.repeat(
-        stmt="StringList_UserList(init_data)",
-        number=1000,
-        repeat=5,
-        globals=globals(),
-    )
-)
-
-print(
-    f"list is {list_initialization / user_list_initialization:.3f}",
-    "times slower than UserList",
-)
-
-
 extended_list = StringList_list(init_data)
-list_extend = min(
-    timeit.repeat(
-        stmt="extended_list.extend(init_data)",
-        number=5,
-        repeat=2,
-        globals=globals(),
+list_extend = (
+    min(
+        timeit.repeat(
+            stmt="extended_list.extend(init_data)",
+            number=5,
+            repeat=2,
+            globals=globals(),
+        )
     )
+    * 1e6
 )
 
 extended_user_list = StringList_UserList(init_data)
-user_list_extend = min(
-    timeit.repeat(
-        stmt="extended_user_list.extend(init_data)",
-        number=5,
-        repeat=2,
-        globals=globals(),
+user_list_extend = (
+    min(
+        timeit.repeat(
+            stmt="extended_user_list.extend(init_data)",
+            number=5,
+            repeat=2,
+            globals=globals(),
+        )
     )
+    * 1e6
 )
 
-print(
-    f"list is {list_extend / user_list_extend:.3f}",
-    "times slower than UserList",
-)
+print(f"StringList_list().extend() time: {list_extend:.2f} μs")
+print(f"StringList_UserList().extend() time: {user_list_extend:.2f} μs")

python-inherit-list-userlist/string_list1.py

@@ -1,7 +1,4 @@
-from collections import UserList
-
-
-class StringList(UserList):
+class StringList(list):
     def __init__(self, iterable):
         super().__init__(str(item) for item in iterable)
 

python-inherit-list-userlist/string_list2.py

@@ -3,7 +3,7 @@
 
 class StringList(UserList):
     def __init__(self, iterable):
-        self.data = [str(item) for item in iterable]
+        super().__init__(str(item) for item in iterable)
 
     def __setitem__(self, index, item):
         self.data[index] = str(item)