QA updates to Replace String Materials (#301)

* QA updates

* QA updates 2

* Final QA updates

Co-authored-by: Geir Arne Hjelle <[email protected]>

Author: iansedano

replace-string-python/transcript_basic.py

@@ -8,17 +8,3 @@
 print(transcript.replace("BLASTED", "😤"))
 
 print(transcript.replace("BLASTED", "😤").replace("Blast", "😤"))
-
-replacements = [
-    ("BLASTED", "😤"),
-    ("Blast", "😤"),
-    ("2022-08-24T", ""),
-    ("+00:00", ""),
-    ("[support_tom]", "Agent"),
-    ("[johndoe]", "Client"),
-]
-
-for old, new in replacements:
-    transcript = transcript.replace(old, new)
-
-print(transcript)

replace-string-python/transcript_multiple_replace.py

@@ -0,0 +1,20 @@
+REPLACEMENTS = [
+    ("BLASTED", "😤"),
+    ("Blast", "😤"),
+    ("2022-08-24T", ""),
+    ("+00:00", ""),
+    ("[support_tom]", "Agent "),
+    ("[johndoe]", "Client"),
+]
+
+transcript = """
+[support_tom] 2022-08-24T10:02:23+00:00 : What can I help you with?
+[johndoe] 2022-08-24T10:03:15+00:00 : I CAN'T CONNECT TO MY BLASTED ACCOUNT
+[support_tom] 2022-08-24T10:03:30+00:00 : Are you sure it's not your caps lock?
+[johndoe] 2022-08-24T10:04:03+00:00 : Blast! You're right!
+"""
+
+for old, new in REPLACEMENTS:
+    transcript = transcript.replace(old, new)
+
+print(transcript)

replace-string-python/transcript_reduce.py

@@ -1,19 +1,20 @@
 from functools import reduce
 
-transcript = """
-[support_tom] 2022-08-24T10:02:23+00:00 : What can I help you with?
-[johndoe] 2022-08-24T10:03:15+00:00 : I CAN'T CONNECT TO MY BLASTED ACCOUNT
-[support_tom] 2022-08-24T10:03:30+00:00 : Are you sure it's not your caps lock?
-[johndoe] 2022-08-24T10:04:03+00:00 : Blast! You're right!
-"""
 
-replacements = [
+REPLACEMENTS = [
     ("BLASTED", "😤"),
     ("Blast", "😤"),
     ("2022-08-24T", ""),
     ("+00:00", ""),
-    ("[support_tom]", "Tom"),
+    ("[support_tom]", "Agent "),
     ("[johndoe]", "Client"),
 ]
 
-print(reduce(lambda acc, item: acc.replace(*item), replacements, transcript))
+transcript = """
+[support_tom] 2022-08-24T10:02:23+00:00 : What can I help you with?
+[johndoe] 2022-08-24T10:03:15+00:00 : I CAN'T CONNECT TO MY BLASTED ACCOUNT
+[support_tom] 2022-08-24T10:03:30+00:00 : Are you sure it's not your caps lock?
+[johndoe] 2022-08-24T10:04:03+00:00 : Blast! You're right!
+"""
+
+print(reduce(lambda acc, item: acc.replace(*item), REPLACEMENTS, transcript))

replace-string-python/transcript_regex.py

@@ -1,22 +1,20 @@
 import re
 
+REGEX_REPLACEMENTS = [
+    (r"blast\w*", "😤"),
+    (r" [-T:+\d]{25}", ""),
+    (r"\[support\w*\]", "Agent "),
+    (r"\[johndoe\]", "Client"),
+]
+
 transcript = """
 [support_tom] 2022-08-24T10:02:23+00:00 : What can I help you with?
 [johndoe] 2022-08-24T10:03:15+00:00 : I CAN'T CONNECT TO MY BLASTED ACCOUNT
 [support_tom] 2022-08-24T10:03:30+00:00 : Are you sure it's not your caps lock?
 [johndoe] 2022-08-24T10:04:03+00:00 : Blast! You're right!
 """
 
-regex_replacements = [
-    (r"blast\w*", "😤"),
-    (r" [-T:\+\d]{25}", ""),
-    (r"\[support\w*\]", "Agent"),
-    (r"\[johndoe\]", "Client"),
-]
-
-for regex_find, regex_replace in regex_replacements:
-    transcript = re.sub(
-        regex_find, regex_replace, transcript, flags=re.IGNORECASE
-    )
+for new, old in REGEX_REPLACEMENTS:
+    transcript = re.sub(new, old, transcript, flags=re.IGNORECASE)
 
 print(transcript)

replace-string-python/transcript_regex_callback.py

@@ -1,14 +1,12 @@
 import re
 
-transcript = """
-[support_tom] 2022-08-24T10:02:23+00:00 : What can I help you with?
-[johndoe] 2022-08-24T10:03:15+00:00 : I CAN'T CONNECT TO MY BLASTED ACCOUNT
-[support_tom] 2022-08-24T10:03:30+00:00 : Are you sure it's not your caps lock?
-[johndoe] 2022-08-24T10:04:03+00:00 : Blast! You're right!
-"""
-
-message_pattern = r"(\[.+\]) ([-T:\+\d]{25}) : (.+)"
 
+ENTRY_PATTERN = (
+    r"\[(.+)\] "  # User string, discarding square brackets
+    r"[-T:+\d]{25} "  # Time stamp
+    r": "  # Separator
+    r"(.+)"  # Message
+)
 BAD_WORDS = ["blast", "dash", "beezlebub"]
 CLIENTS = ["johndoe", "janedoe"]
 
@@ -19,16 +17,25 @@ def censor_bad_words(message):
     return message
 
 
-def censor_clients(user):
-    for client in CLIENTS:
-        user = re.sub(rf"\[{client}\]", "Client", user)
-    return user
+def censor_users(user):
+    if user.startswith("support"):
+        return "Agent"
+    elif user in CLIENTS:
+        return "Client"
+    else:
+        raise ValueError(f"unknown client: '{user}'")
 
 
 def sanitize_message(match):
-    user, _, message = match.groups()
-    user = re.sub(r"\[.*support.*\]", "Agent", user)
-    return f"{censor_clients(user)} : {censor_bad_words(message)}"
+    user, message = match.groups()
+    return f"{censor_users(user):<6} : {censor_bad_words(message)}"
 
 
-print(re.sub(message_pattern, sanitize_message, transcript))
+transcript = """
+[support_tom] 2022-08-24T10:02:23+00:00 : What can I help you with?
+[johndoe] 2022-08-24T10:03:15+00:00 : I CAN'T CONNECT TO MY BLASTED ACCOUNT
+[support_tom] 2022-08-24T10:03:30+00:00 : Are you sure it's not your caps lock?
+[johndoe] 2022-08-24T10:04:03+00:00 : Blast! You're right!
+"""
+
+print(re.sub(ENTRY_PATTERN, sanitize_message, transcript))