Post final QA fixes

Author: bzaczynski

python-namedtuple/database.py

@@ -0,0 +1,10 @@
+def get_column_names(table):
+    if table == "passenger":
+        return ("id", "first_name", "last_name", "class")
+    raise ValueError(f"unknown table {table}")
+
+
+def get_passenger_by_id(passenger_id):
+    if passenger_id == 1234:
+        return (1234, "John", "Doe", "Business")
+    raise ValueError(f"no record with id={passenger_id}")

python-namedtuple/employees.py

@@ -1,9 +1,9 @@
 import csv
 from collections import namedtuple
 
-with open("employees.csv", "r", encoding="utf-8") as csv_file:
+with open("employees.csv", mode="r", encoding="utf-8") as csv_file:
     reader = csv.reader(csv_file)
     Employee = namedtuple("Employee", next(reader), rename=True)
     for row in reader:
         employee = Employee(*row)
-        print(employee.name, employee.job, employee.email)
+        print(employee)

python-namedtuple/namedtuple_dataclass_memory.py

@@ -17,5 +17,5 @@ class PointDataClass:
 dataclass_memory = asizeof.asizeof(PointDataClass(x=1, y=2, z=3))
 gain = 100 - namedtuple_memory / dataclass_memory * 100
 
-print(f"namedtuple: {namedtuple_memory} bytes ({gain:.2f}% lower)")
+print(f"namedtuple: {namedtuple_memory} bytes ({gain:.2f}% smaller)")
 print(f"data class: {dataclass_memory} bytes")

python-namedtuple/passenger.py

@@ -0,0 +1,5 @@
+from collections import namedtuple
+
+from database import get_column_names
+
+Passenger = namedtuple("Passenger", get_column_names("passenger"), rename=True)

python-namedtuple/performance.py

@@ -11,3 +11,8 @@ class Person:
 
     def __iter__(self):
         return iter(astuple(self))
+
+
+jane = Person("Jane", 25, 1.75, 67)
+for field in jane:
+    print(field)

python-namedtuple/person_dataclass.py

@@ -0,0 +1 @@
+pympler

python-namedtuple/requirements.txt

@@ -11,15 +11,15 @@ class Person(BasePerson):
 
     __slots__ = ()
 
-    def __repr__(self):
+    def __str__(self):
         return f"Name: {self.name}, age: {self.age} years old."
 
     @property
     def age(self):
         return (date.today() - self.birthdate).days // 365
 
 
-Person.__doc__
+print(Person.__doc__)
 
 jane = Person("Jane", date(1996, 3, 5))
 print(jane.age)

python-namedtuple/subclass.py

@@ -34,7 +34,6 @@ class PointTypedNamedTuple(NamedTuple):
 typed_namedtuple_time = average_time(
     PointTypedNamedTuple(x=1, y=2, z=3), time_structure
 )
-gain = typed_namedtuple_time / namedtuple_time
 
 print(f"namedtuple:        {namedtuple_time:.2f} ns")
 print(f"typing.NamedTuple: {typed_namedtuple_time:.2f} ns")