Merge branch 'master' into python-selenium

Author: martin-martin

duckdb/README.md

@@ -1,9 +1,9 @@
-These files will allow you to work along with the [Introducing DuckDB](https://realpython.com/introducing-duckdb/) tutorial.
+These files will allow you to work along with the [Introducing DuckDB](https://realpython.com/python-duckdb/) tutorial.
 
 The files are:
 
-Code Download.ipynb	- Contains the code you see in the tutorial.
-parties.json		- JSON file containing political party information.
-presidents.csv	    	- CSV file containing president information.
-presidents.parquet	- Parquet file containing president information.
+- `duckdb_code.ipynb`: Contains the code you see in the tutorial.
+- `parties.json`: JSON file containing political party information.
+- `presidents.csv`: CSV file containing president information.
+- `presidents.parquet`: Parquet file containing president information.
 

duckdb/Code Download.ipynb duckdb/duckdb_code.ipynbduckdb/Code Download.ipynb renamed to duckdb/duckdb_code.ipynb

@@ -88,8 +88,10 @@
    "source": [
     "**This code won't work.**\n",
     "\n",
+    "```python\n",
     "with duckdb.connect(database=\"presidents.db\") as conn:\n",
-    "    conn.sql(\"SELECT * FROM presidents_relation\")\n"
+    "    conn.sql(\"SELECT * FROM presidents_relation\")\n",
+    "```"
    ]
   },
   {
@@ -343,10 +345,10 @@
     "    print(\n",
     "        conn.sql(\n",
     "            \"\"\"\n",
-    "        SELECT last_name, first_name\n",
-    "        FROM presidents\n",
-    "        WHERE sequence = 1\n",
-    "        \"\"\"\n",
+    "            SELECT last_name, first_name\n",
+    "            FROM presidents\n",
+    "            WHERE sequence = 1\n",
+    "            \"\"\"\n",
     "        )\n",
     "    )"
    ]
@@ -391,7 +393,9 @@
    "source": [
     "**Only run this code if you need to update your existing `short_name()` function**\n",
     "\n",
-    "duckdb.remove_function(\"short_name\")"
+    "```python\n",
+    "duckdb.remove_function(\"short_name\")\n",
+    "```"
    ]
   },
   {
@@ -450,15 +454,15 @@
     "import duckdb\n",
     "\n",
     "with duckdb.connect(\"presidents.db\") as conn:\n",
-    "    pandas_df = conn.sql(\n",
+    "    pandas_presidents = conn.sql(\n",
     "        \"\"\"\n",
     "        SELECT last_name, first_name\n",
     "        FROM presidents\n",
     "        WHERE sequence BETWEEN 2 AND 5\n",
     "        \"\"\"\n",
     "    ).df()\n",
     "\n",
-    "pandas_df"
+    "pandas_presidents"
    ]
   },
   {

python-code-quality/functionality.py

@@ -2,7 +2,7 @@
 #     return a + b
 
 
-def add_numbers(a: int | float, b: int | float) -> int | float:
+def add_numbers(a: int | float, b: int | float) -> float:
     a, b = float(a), float(b)
     return a + b
 

python-code-quality/testability.py

@@ -1,19 +1,19 @@
 # import pytest
 
 # def greet(name):
-#     print(f"Hello, {name}")
+#     print(f"Hello, {name}!")
 
 
 # def test_greet(capsys):
 #     greet("Alice")
 #     captured = capsys.readouterr()
-#     assert captured.out.strip() == "Hello, Alice"
+#     assert captured.out.strip() == "Hello, Alice!"
 
 
 def greet(name: str) -> str:
-    return f"Hello, {name}"
+    return f"Hello, {name}!"
 
 
 # Easy to test
 def test_greet():
-    assert greet("Alice") == "Hello, Alice"
+    assert greet("Alice") == "Hello, Alice!"