Make the 'features' argument of Window.open_ optional (#166)

Author: malthe

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Changed `Window.open_` to have optional `features` argument
 
 ### 0.15.5 - (2019-10-09)
 * Added `keypress` event handler API

lib/js/tests/Webapi/Webapi__Dom/Webapi__Dom__Window__test.js

@@ -120,6 +120,8 @@ window.moveTo(120, 300);
 
 window.open("http://...", "my window", "menubar=yes");
 
+window.open("http://...", "my window", undefined);
+
 window.postMessage("my message", "*");
 
 window.print();

src/Webapi/Webapi__Dom/Webapi__Dom__Window.re

@@ -77,7 +77,7 @@ module Impl = (T: {type t;}) => {
   [@bs.send.pipe : t_window] external matchMedia : string => mediaQueryList = ""; /* experimental, CSSOM View module */
   [@bs.send.pipe : t_window] external moveBy : (int, int) => unit = ""; /* experimental, CSSOM View module */
   [@bs.send.pipe : t_window] external moveTo : (int, int) => unit = ""; /* experimental, CSSOM View module */
-  [@bs.send.pipe : t_window] [@bs.return nullable] external open_ : (~url: string, ~name: string, ~features: string) => option(Dom.window) = "open"; /* yes, features is a stringly typed list of key value pairs, sigh */
+  [@bs.send.pipe : t_window] [@bs.return nullable] external open_ : (~url: string, ~name: string, ~features: string=?) => option(Dom.window) = "open"; /* yes, features is a stringly typed list of key value pairs, sigh */
   [@bs.send.pipe : t_window] external postMessage : ('a, string) => unit = ""; /* experimental-ish?, Web Messaging */
   [@bs.send.pipe : t_window] external postMessageWithTransfers : ('a, string, array(transferable)) => unit = "postMessage"; /* experimental-ish?, Web Messaging */
   [@bs.send.pipe : t_window] external print : unit = "";

tests/Webapi/Webapi__Dom/Webapi__Dom__Window__test.re

@@ -59,6 +59,7 @@ let _ = Window.matchMedia("max-height: 400", window);
 let _ = Window.moveBy(10, (-10), window);
 let _ = Window.moveTo(120, 300, window);
 let _ = Window.open_(~url="http://...", ~name="my window", ~features="menubar=yes", window);
+let _ = Window.open_(~url="http://...", ~name="my window", window);
 Window.postMessage("my message", "*", window) /* Currently no way to make transferables */; /*Window.postMessageWithTransfers "my message" "*" transfers window;*/
 Window.print(window);
 let _ = Window.prompt("type you password, please?", window);