handle possible errors

Author: Rusty Key

src/formatters/ocaml.ts

@@ -1,9 +1,8 @@
 import { execSync } from "child_process";
 import * as fs from "fs";
-import * as path from "path";
 import { v4 as uuidv4 } from "uuid";
 import * as vscode from "vscode";
-import { getFullTextRange } from "./utils";
+import { getFormatter, getFullTextRange } from "./utils";
 
 export function register() {
   const configuration = vscode.workspace.getConfiguration("reason");
@@ -13,21 +12,28 @@ export function register() {
     { scheme: "file", language: "ocaml" },
     {
       provideDocumentFormattingEdits(_document: vscode.TextDocument): vscode.TextEdit[] {
-        const formatterPath = configuration.get<string | undefined>("path.ocamlformat");
-        const formatter = formatterPath ? path.resolve(rootPath, formatterPath) : "ocamlformat";
         const textEditor = vscode.window.activeTextEditor;
+        const formatter = getFormatter(configuration, "ocamlformat");
+
+        console.log(formatter);
+
+        if (!formatter) return [];
 
         if (textEditor) {
           const tempFileName = `/tmp/vscode-reasonml-${uuidv4()}.ml`;
           fs.writeFileSync(tempFileName, textEditor.document.getText(), "utf8");
-          const filePath = textEditor.document.fileName;
-          const formattedText = execSync(
-            `cd ${rootPath} && ${formatter} --name=${filePath} ${tempFileName}`,
-          ).toString();
-          fs.unlinkSync(tempFileName);
-
-          const textRange = getFullTextRange(textEditor);
-          return [vscode.TextEdit.replace(textRange, formattedText)];
+          try {
+            const filePath = textEditor.document.fileName;
+            const formattedText = execSync(
+              `cd ${rootPath} && ${formatter} --name=${filePath} ${tempFileName}`,
+            ).toString();
+            const textRange = getFullTextRange(textEditor);
+            fs.unlinkSync(tempFileName);
+            return [vscode.TextEdit.replace(textRange, formattedText)];
+          } catch (e) {
+            fs.unlinkSync(tempFileName);
+            return [];
+          }
         } else {
           return [];
         }

src/formatters/reason.ts

@@ -1,29 +1,33 @@
 import { execSync } from "child_process";
 import * as fs from "fs";
-import * as path from "path";
 import { v4 as uuidv4 } from "uuid";
 import * as vscode from "vscode";
-import { getFullTextRange } from "./utils";
+import { getFormatter, getFullTextRange } from "./utils";
 
 export function register() {
   const configuration = vscode.workspace.getConfiguration("reason");
-  const rootPath = vscode.workspace.rootPath || "";
 
   vscode.languages.registerDocumentFormattingEditProvider(
     { scheme: "file", language: "reason" },
     {
       provideDocumentFormattingEdits(_document: vscode.TextDocument): vscode.TextEdit[] {
-        const formatterPath = configuration.get<string | undefined>("path.refmt");
-        const formatter = formatterPath ? path.resolve(rootPath, formatterPath) : "/usr/local/bin/refmt";
         const textEditor = vscode.window.activeTextEditor;
+        const formatter = getFormatter(configuration, "refmt");
+
+        if (!formatter) return [];
+
         if (textEditor) {
           const tempFileName = `/tmp/vscode-refmt-${uuidv4()}.re`;
           fs.writeFileSync(tempFileName, textEditor.document.getText(), "utf8");
-          const formattedText = execSync(`${formatter} ${tempFileName}`).toString();
-          const textRange = getFullTextRange(textEditor);
-          fs.unlinkSync(tempFileName);
-
-          return [vscode.TextEdit.replace(textRange, formattedText)];
+          try {
+            const formattedText = execSync(`${formatter} ${tempFileName}`).toString();
+            const textRange = getFullTextRange(textEditor);
+            fs.unlinkSync(tempFileName);
+            return [vscode.TextEdit.replace(textRange, formattedText)];
+          } catch (e) {
+            fs.unlinkSync(tempFileName);
+            return [];
+          }
         } else {
           return [];
         }

src/formatters/utils.ts

@@ -1,3 +1,5 @@
+import { execSync } from "child_process";
+import * as path from "path";
 import * as vscode from "vscode";
 
 export function getFullTextRange(textEditor: vscode.TextEditor) {
@@ -11,3 +13,27 @@ export function getFullTextRange(textEditor: vscode.TextEditor) {
     lastLine.range.end.character,
   );
 }
+
+function getExecutablePath(executable: string) {
+  try {
+    return execSync(`which ${executable}`).toString();
+  } catch (_e) {
+    return null;
+  }
+}
+
+export function getFormatter(configuration: vscode.WorkspaceConfiguration, formatterName: string) {
+  const rootPath = vscode.workspace.rootPath || "";
+  const formatterPath = configuration.get<string | undefined>(`path.${formatterName}`) || formatterName;
+
+  const formatter =
+    formatterPath === formatterName ? getExecutablePath(formatterName) : path.resolve(rootPath, formatterPath);
+
+  if (!formatter) {
+    vscode.window.showInformationMessage(
+      `${formatterPath} is not available. Please specify "vscode-reasonml.path.${formatterName}"`,
+    );
+  }
+
+  return formatter;
+}