Skip to content

Edge implementation duplicationΒ #94

@phenomnomnominal

Description

@phenomnomnominal

Describe the bug

As part of the performance improvements done to handle many edges, we had to introduce a split implementation. There is one for a small number of edges which can have animations, and one for a large number of edges which cannot have animations.

The current high perf implementation can either have animations or allow adding and removing nodes. Right now, the whole mesh is recreated when the list of nodes changes, so animating between the two sets of vertex positions is all over the place. Having both would require changing the implementation so that the mesh vertex indices remain stable as nodes are added/removed.

Steps to Reproduce the Bug or Issue

Look at the code

Expected behavior

One implementation for Egde

Screenshots or Videos

No response

Platform

  • Reagraph Version: [e.g. 1.0.0]
  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • NodeJS version: ...

Your Example Website or App

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions